Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump google-network & awk-eks benchmark thresholds #863

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Apr 8, 2022

This is to address the recent nightly failures:

{
  "Status": "fail",
  "Diffs": [
    {
      "Status": "fail",
      "Package": "github.com/hashicorp/terraform-ls/internal/langserver/handlers",
      "Benchmark": "BenchmarkInitializeFolder_basic/google-network-2",
      "Value": 2622.730844
    }
  ],
  "Thresholds": {
    "Min": 1430,
    "Max": 2470
  }
}

https://github.com/hashicorp/terraform-ls/runs/5879240603?check_suite_focus=true#step:9:1

{
  "Status": "fail",
  "Diffs": [
    {
      "Status": "fail",
      "Package": "github.com/hashicorp/terraform-ls/internal/langserver/handlers",
      "Benchmark": "BenchmarkInitializeFolder_basic/aws-eks-2",
      "Value": 2874.628341
    }
  ],
  "Thresholds": {
    "Min": 1570,
    "Max": 2500
  }
}

https://github.com/hashicorp/terraform-ls/runs/5965803013?check_suite_focus=true#step:9:1

@radeksimko radeksimko added the ci Continuous integration/delivery related label Apr 8, 2022
@radeksimko radeksimko requested a review from a team as a code owner April 8, 2022 07:56
@radeksimko radeksimko changed the title ci: bump google-network benchmark threshold ci: bump google-network & awk-eks benchmark thresholds Apr 11, 2022
@radeksimko radeksimko self-assigned this Apr 11, 2022
@radeksimko radeksimko added this to the v0.27.0 milestone Apr 11, 2022
@radeksimko radeksimko merged commit f49cd99 into main Apr 11, 2022
@radeksimko radeksimko deleted the bump-benchmark-threshold branch April 11, 2022 09:17
@github-actions
Copy link

This functionality has been released in v0.27.0 of the language server.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants