Provide completion, hover and docs links for uninitialized Registry modules #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
jpogran
force-pushed
the
gh-599-tf-registry-auto-complete
branch
4 times, most recently
from
b1e9d84 to
5d81f68
Compare
radeksimko
force-pushed
the
gh-599-tf-registry-auto-complete
branch
7 times, most recently
from
63b451d to
3811e61
Compare
radeksimko
force-pushed
the
gh-599-tf-registry-auto-complete
branch
from
372c3fb to
d8ee645
Compare
2 tasks
radeksimko
approved these changes
Jun 17, 2022
radeksimko
changed the title
2 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on hashicorp/terraform-schema#113
Fixes #599
UX
This impacts completion, hover, and docs link, as shown.
Screen.Recording.2022-06-17.at.17.05.48.mov
The slightly awkwardly formatted description of
activate_api_identitieshover data is a result of the description being indented, which implies code block in Markdown.https://github.com/terraform-google-modules/terraform-google-project-factory/blob/37cf73779f2efa750cee09c57516c5eccb986501/variables.tf#L105-L110
From what I can tell, module authors do use Markdown in descriptions, so this seems more like an accidental oversight.