Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide basic IntelliSense (except for diagnostics) for hidden *.tf files #971

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jun 27, 2022

Closes #972

Depends on #968


I label this as enhancement, since Terraform itself doesn't really load hidden files. We can however be more pragmatic about this and still provide some IntelliSense within. The only thing we do not provide is diagnostics, see more on that in #970

Before

Screenshot 2022-06-27 at 12 43 18

After

Screenshot 2022-06-27 at 12 43 55

@radeksimko radeksimko added the enhancement New feature or request label Jun 27, 2022
@radeksimko radeksimko added this to the v0.29.0 milestone Jun 27, 2022
@radeksimko radeksimko force-pushed the b-avoid-diags-for-hidden-tf branch from 1b73798 to 674d5fa Compare June 27, 2022 11:59
@radeksimko radeksimko force-pushed the b-avoid-diags-for-hidden-tf branch from 674d5fa to e13d7bd Compare June 27, 2022 18:02
@radeksimko radeksimko assigned radeksimko and unassigned radeksimko Jun 27, 2022
@radeksimko radeksimko marked this pull request as ready for review June 27, 2022 18:03
@radeksimko radeksimko requested a review from a team as a code owner June 27, 2022 18:03
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@radeksimko radeksimko merged commit 0dd0019 into main Jun 30, 2022
@radeksimko radeksimko deleted the b-avoid-diags-for-hidden-tf branch June 30, 2022 11:46
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error thrown when saving .tf or .tfvars files with names beginning with a dot
2 participants