Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch dependency mitchell/cli to hashicorp/cli #112

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Switch dependency mitchell/cli to hashicorp/cli #112

merged 1 commit into from
Dec 21, 2023

Conversation

austinvalle
Copy link
Member

@austinvalle austinvalle commented Dec 20, 2023

Closes #110

One interesting tidbit, the tools module still has an indirect reference to mitchellh/cli because of github.com/hashicorp/copywrite.... The copywrite CLI doesn't actually use mitchell/cli directly but has an indirect reference to it as well 😄

The chain of dependency for both tools/go.sum references:

  • github.com/mitchellh/cli@v1.1.0
  • github.com/hashicorp/serf@v0.9.6
  • github.com/hashicorp/consul/api@v1.13.0
  • github.com/knadh/koanf@v1.5.0
  • github.com/hashicorp/copywrite@v0.18.0 🎯

And the other:

  • github.com/mitchellh/cli@v1.0.0
  • github.com/hashicorp/go-sockaddr@v1.0.2
  • github.com/hashicorp/vault/sdk@v0.1.13
  • github.com/hashicorp/vault/api@v1.0.4
  • github.com/knadh/koanf@v1.5.0
  • github.com/hashicorp/copywrite@v0.18.0 🎯

Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@austinvalle austinvalle merged commit f809dfa into main Dec 21, 2023
2 checks passed
@austinvalle austinvalle deleted the av/cli branch December 21, 2023 14:43
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from mitchellh/cli to hashicorp/cli
2 participants