Fix title and reference links of nested blocks/attributes

[zippolyte]

The path slice needs to be made a copy of the parents, otherwise when there is enough nesting, the append operation does not do a copy of the slice, and we keep modifying the same reference in the nested blocks, thus generating incorrect titles and links.

As an example, you can check https://registry.terraform.io/providers/DataDog/datadog/2.25.0/docs/resources/dashboard#nestedblock--widget--change_definition--request--apm_query, which is the level of nesting things start to go bad. The title shows the wrong path, but the anchor ID is still ok at this point.

Related issue: DataDog/terraform-provider-datadog#1024

[hashicorp-cla]

All committers have signed the CLA.

[mavogel]

@paultyng can we get this merged? The markdown link checker action also triggers on this.

[displague]

Wondering if this is also related to #28

[detro]

Hello @zippolyte - thank you so much for this and the patience.

I frankly had to do a bit of studying and testing to figure out what it is you were fixing: I wasn't part of the original creators of this, so I was like :head-scratch:-ing hard.

Then I found this https://stackoverflow.com/questions/35276022/unexpected-slice-append-behaviour and https://go.dev/play/p/INADVS3Ats. I have also been able to assemble an even weirder example, that shows that this issue with append() might be a genuine bug with the internal Go implementation: https://go.dev/play/p/M4-d16YwdN0

It's likely something with how Go is manipulating the memory created as part of the initial calls to append() and also what it does when it has to access and print it.

Will be merging this.

[detro]

See #56 (comment)

Thank you so much

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.