Skip to content

Conversation

yottta
Copy link

@yottta yottta commented Apr 10, 2025

Fixes #282.

The PreferWriteOnlyAttribute validator is misconfigured in terms that the client capabilities received in the request are not given to the validator. Therefore, any call to validate will return no error rendering the validator useless.

This PR is passing over the client capabilities to the validator.

Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
@yottta yottta requested a review from a team as a code owner April 10, 2025 14:18
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@yottta
Copy link
Author

yottta commented Apr 10, 2025

I will read and sign the CLA next week. In case somebody that is already having this signed can apply the changes, please, go ahead.

@rainkwan
Copy link

Hi @yottta, thank you for the contribution!

In addition to signing the CLA, can you also add a changelog entry for this PR marked as BUG FIXES?

@rainkwan rainkwan added this to the v0.18.0 milestone Apr 14, 2025
Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
This was referenced Apr 21, 2025
yottta added 2 commits April 23, 2025 13:03
Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
@yottta
Copy link
Author

yottta commented Apr 23, 2025

I will read and sign the CLA next week. In case somebody that is already having this signed can apply the changes, please, go ahead.

I didn't forget about this. I am still waiting for some information before signing the CLA.

Meanwhile, I wouldn't mind if anybody could merge the changes

@rainkwan rainkwan removed this from the v0.18.0 milestone May 8, 2025
@rainkwan
Copy link

Hi @yottta,

Thank you again for your contribution. It looks like this bug got fixed in this PR so I am going to go ahead and close this one.

@rainkwan rainkwan closed this May 12, 2025
@yottta
Copy link
Author

yottta commented May 12, 2025

Thanks a lot @rainkwan! Sorry for not being able to merge this on my own.
Then I will also close #282.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PreferWriteOnlyAttribute validator is not making use of the client capabilities
2 participants