Fix configvalidator dropping previous diags

[skirsten]

Before if you had something like this

return []resource.ConfigValidator{
  resourcevalidator.ExactlyOneOf(
    path.MatchRoot("a"),
    path.MatchRoot("b"),
  ),
  resourcevalidator.ExactlyOneOf(
    path.MatchRoot("c"),
    path.MatchRoot("d"),
  ),
}

the second validator overwrites the diags from the first one, ignoring it completely.

Alternatively this could also be fixed in the framework itself like here:

for _, blockValidator := range block.SetValidators() {
  // Instantiate a new response for each request to prevent validators
  // from modifying or removing diagnostics.

[hashicorp-cla]

All committers have signed the CLA.

[bflad]

Hi @skirsten 👋 Thank you for submitting this!

Rather than expecting all validators to properly "passthrough" validation diagnostics, I think I agree with your second idea here of fixing the framework to treat each validator separately. Would you be willing to submit that fix upstream?

Thanks again. 😄

[bflad]

terraform-plugin-framework v1.1.0 has been released which should fix this. Thanks for the upstream fix, @skirsten!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.