fwserver: add list resources to GetMetadata
#1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbasata
force-pushed
the
add-list-to-fwserver
branch
2 times, most recently
from
e790c83 to
c57458a
Compare
1 task
bbasata
force-pushed
the
add-list-to-fwserver
branch
2 times, most recently
from
586bdca to
f971285
Compare
bbasata
force-pushed
the
add-list-to-fwserver
branch
from
485abb7 to
4dd9564
Compare
bbasata
force-pushed
the
add-list-to-fwserver
branch
from
4dd9564 to
7a0dfb3
Compare
bbasata
commented
Jun 3, 2025
| defer s.listResourceFuncsMutex.Unlock() | ||
|
|
||
| if s.listResourceFuncs != nil { | ||
| return s.listResourceFuncs, s.resourceTypesDiags |
There was a problem hiding this comment.
s.resourceTypesDiags is the wrong diags here. This is fixed in a follow-up pull request.
rainkwan
approved these changes
Jun 4, 2025
| sort.Slice(response.Resources, func(i int, j int) bool { | ||
| return response.Resources[i].TypeName < response.Resources[j].TypeName | ||
| }) | ||
|
|
||
| if diff := cmp.Diff(response, testCase.expectedResponse); diff != "" { | ||
| opts := cmp.Options{ |
There was a problem hiding this comment.
Just curious, what effect does adding this have?
There was a problem hiding this comment.
The test will ignore the difference between []ListResource{} and nil. So it ignores the difference between the empty slice that GetMetadata returns by default and the default zero value for GetMetadataResponse.ListResources.
So the effect is: no need to add []ListResource{} to every test.
austinvalle
reviewed
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds list resource metadata to the protocol-independent framework server implementation of
GetMetadata.Rollback Plan
Changes to Security Controls
No