Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/fwserver: Add Attribute validation for missing required and invalid read-only configurations #370

Merged
merged 4 commits into from
Jun 13, 2022
Merged

internal/fwserver: Add Attribute validation for missing required and invalid read-only configurations #370

merged 4 commits into from
Jun 13, 2022

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 9, 2022

Closes #276

@bflad bflad added the enhancement New feature or request label Jun 9, 2022
@bflad bflad added this to the v0.9.0 milestone Jun 9, 2022
@bflad bflad requested a review from a team as a code owner June 9, 2022 20:56
bendbennett
bendbennett approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

detro
detro approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@detro detro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👩‍🍳 💋

@bflad bflad merged commit c76b9a4 into main Jun 13, 2022
@bflad bflad deleted the bflad-additional-attribute-validations branch June 13, 2022 17:35
@bflad bflad mentioned this pull request Jun 21, 2022
Open
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

@detro detro detro approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

Computed only attributes present provider bug error when configured.
3 participants
@bflad @detro @bendbennett