Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attr.Value access design doc. #69

Merged
merged 3 commits into from
Jul 16, 2021
Merged

Conversation

paddycarver
Copy link
Contributor

Add a design doc describing the problem of accessing a single
attribute's value, and proposing a solution for it.

@paddycarver paddycarver added the design-doc Issues or pull requests about a design document, capturing design ideas and trade-offs. label Jul 15, 2021
@paddycarver paddycarver requested review from bflad and kmoe July 15, 2021 14:24
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the best path forward.

Copy link
Member

@kmoe kmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/design/attr-value-access.md Outdated Show resolved Hide resolved
paddycarver and others added 3 commits July 16, 2021 09:10
Add a design doc describing the problem of accessing a single
attribute's value, and proposing a solution for it.
Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com>
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@paddycarver paddycarver force-pushed the paddy_attr_value_access_design branch from 23c4b9f to 5b4c4e6 Compare July 16, 2021 16:10
@paddycarver paddycarver merged commit dacb915 into main Jul 16, 2021
@paddycarver paddycarver deleted the paddy_attr_value_access_design branch July 16, 2021 16:16
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design-doc Issues or pull requests about a design document, capturing design ideas and trade-offs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants