types/basetypes: Reduce memory allocations of (ObjectValue).ToTerraformValue() #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmValue() Reference: #775 The prior implementation used the exported `AttributeTypes()` method, which in this case was unnecessarily creating a copy of the map when it was only be used for walking the existing data. At scale, such as handling 1000+ objects, this creates unnecessary pressure on the Go garbage collector. `benchstat` comparison with new benchmark test: ```text goos: darwin goarch: arm64 pkg: github.com/hashicorp/terraform-plugin-framework/types/basetypes │ original │ proposed │ │ sec/op │ sec/op vs base │ ObjectValueToTerraformValue1000-10 408.4µ ± 1% 318.4µ ± 1% -22.02% (p=0.000 n=10) │ original │ proposed │ │ B/op │ B/op vs base │ ObjectValueToTerraformValue1000-10 449.2Ki ± 0% 286.6Ki ± 0% -36.19% (p=0.000 n=10) │ original │ proposed │ │ allocs/op │ allocs/op vs base │ ObjectValueToTerraformValue1000-10 2.051k ± 0% 2.020k ± 0% -1.51% (p=0.000 n=10) ```
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #775
The prior implementation used the exported
AttributeTypes()method, which in this case was unnecessarily creating a copy of the map when it was only be used for walking the existing data. At scale, such as handling 1000+ objects, this creates unnecessary pressure on the Go garbage collector.benchstatcomparison with new benchmark test: