reflect: Determine equivalency of float32 or float64, and *big.Float via string representation #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * The reflect.Number function was handling float32 and float64 values by determining whether the value in the *big.Float generated through calling val.As() was an exact representation by examining the accuracy produced when calling Float32() or Float64() on the *big.Float * The reflect.Number function has been altered to verify whether the string representation, generated by calling Text(), of the generated *big.Float and a *big.Float created from the float32 or float64 value are identical
bendbennett
added
bug
bendbennett
added a commit
to hashicorp/terraform-provider-corner
that referenced
this pull request
Feb 22, 2024
Latest terraform-plugin-framework contains fix for: * hashicorp/terraform-plugin-framework#914 * hashicorp/terraform-plugin-framework#919
bendbennett
added a commit
to hashicorp/terraform-provider-corner
that referenced
this pull request
Mar 6, 2024
* Adding function tests for framework protocol 5 & 6 and protocol 6 mux providers (#202) * Adding copyright headers (#202) * Linting (#202) * Adding function tests for protocol v5 and protocol v6 providers (#202) * Amending provider defined function tests for number until bug fix on go.cty is released (#202) * Adding function testing for mux providers (#202) * Adding function testing for tf6to5provider (#202) * Adding copyright headers (#202) * Bumping terraform-plugin-framework version to latest (#202) Latest terraform-plugin-framework contains fix for: * hashicorp/terraform-plugin-framework#914 * hashicorp/terraform-plugin-framework#919 * Bumping terraform-plugin-testing to v1.7.0 (#202) * Refactoring to return function.FuncError (#202) * Updates following code review (#202)
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #914