Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tfprotov5+tfprotov6: Additional Go documentation for private state handling #193

Merged
merged 1 commit into from
May 16, 2022
Merged

tfprotov5+tfprotov6: Additional Go documentation for private state handling #193

merged 1 commit into from
May 16, 2022

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 13, 2022

Closes #192

@bflad bflad added the documentation Improvements or additions to documentation label May 13, 2022
@bflad bflad requested a review from alexsomesan May 13, 2022 16:57
@bflad bflad requested a review from a team as a code owner May 13, 2022 16:57
@bflad bflad added this to the v0.10.0 milestone May 13, 2022
bendbennett
bendbennett approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alexsomesan
alexsomesan approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Looks good.

@bflad bflad merged commit 04fb266 into main May 16, 2022
@bflad bflad deleted the bflad-private-state-docs branch May 16, 2022 17:28
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

@alexsomesan alexsomesan alexsomesan approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

Document Private State Quirks
3 participants
@bflad @alexsomesan @bendbennett