Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust function signature of NewMuxServer in tf5muxserver/tf6muxserver to return *muxServer #173

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Adjust function signature of NewMuxServer in tf5muxserver/tf6muxserver to return *muxServer #173

merged 2 commits into from
Jun 29, 2023

Conversation

bendbennett
Copy link
Contributor

Closes: #172

@bendbennett bendbennett added the bug Something isn't working label Jun 29, 2023
@bendbennett bendbennett added this to the v0.11.1 milestone Jun 29, 2023
@bendbennett bendbennett requested a review from a team as a code owner June 29, 2023 15:31
bflad
bflad approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀 Some minor changelog suggestions

.changes/unreleased/BUG FIXES-20230629-162839.yaml Outdated Show resolved Hide resolved
.changes/unreleased/BUG FIXES-20230629-162851.yaml Outdated Show resolved Hide resolved
@bendbennett @bflad
Apply suggestions from code review
77c06e6 
Co-authored-by: Brian Flad <bflad417@gmail.com>
@bendbennett bendbennett merged commit 052a907 into main Jun 29, 2023
@bendbennett bendbennett deleted the bendbennett/issues-172 branch June 29, 2023 15:43
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.11.1
Development

Successfully merging this pull request may close these issues.

Adjust function signature of NewMuxServer in tf5muxserver/tf6muxserver to return *muxServer
2 participants
@bendbennett @bflad