helper/resource.TestCheckResourceAttrPair() Does Not Return Error If Comparing Self

[bflad]

SDK version

v1.7.0

Relevant provider source code

// Usually less obvious with variable usage
resource.TestCheckResourceAttrPair("example_thing.test", "attr", "example_thing.test", "attr"),

Terraform Configuration Files

N/A -- can be covered via unit testing

Expected Behavior

The acceptance testing function should return an error saying the same resource state values are being checked against each other, which will always pass. It is more likely the developer intended to check either different attributes in the same resource (seems like an odd case, but should be still allowed) or different resources (most likely; e.g. checking data source attribute versus resource attribute).

Actual Behavior

No errors returned by TestCheckResourceAttrPair() and acceptance testing passes.

Steps to Reproduce

TF_ACC=1 go test ./... -count=1 -run='ExampleThing_' -v

References

• data source for a step function state machine terraform-provider-aws#10932 (comment)

[paultyng]

Going to close this since the PR was merged in v2.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.