Remove TF_SCHEMA_PANIC_ON_ERR #462
Conversation
| @@ -18,11 +18,6 @@ import ( | |||
| ) | |||
|
|
|||
| func init() { | |||
| // TODO: Remove when we remove the guard on id checks | |||
There was a problem hiding this comment.
This is not referenced anywhere else
| oldEnv := os.Getenv(PanicOnErr) | ||
|
|
||
| os.Setenv(PanicOnErr, "false") | ||
| os.Setenv("TF_ACC", "") |
There was a problem hiding this comment.
oh god this is just asking for a race condition problem 😭
There was a problem hiding this comment.
Agreed, these unit tests aren't super high value so we could ditch the tests if you find this too "anti pattern"
Schema errors will panic if TF_ACC is set, it is no longer on by default but cannot be opted out of when running acceptance tests.
There was a problem hiding this comment.
It would make me very happy if we at least logged the error, from the SDK level, to ensure that if we're going to fail quietly, we at least make some sound about it, even if the user doesn't see it, so it's not discovered an hour into a debug session. We know what happened, we know exactly what went wrong, we should just put it in the logs as an error or warning level, to leave a trail for whatever poor soul has to puzzle through a bug report.
|
@paddycarver no problem will do. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Schema errors will panic if TF_ACC is set, panicking is no longer on by default
but cannot be opted out of when running acceptance tests. This does not address #455 .
Technically a breaking change
schema.PanicOnErris no longer an exported varCloses #451