Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing SetPartial and Partial Deprecation from v2 upgrade guide #484

Closed
paddycarver opened this issue Jun 26, 2020 · 3 comments · Fixed by hashicorp/terraform-website#1374
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@paddycarver
Copy link
Contributor

Our upgrade guide makes no mention of the deprecation of ResourceData.Partial and ResourceData.SetPartial that we talk about in #312 and have subsequently evolved our understanding of. We should document that situation for users upgrading.

@paddycarver paddycarver added the documentation Improvements or additions to documentation label Jun 26, 2020
@paddycarver paddycarver added this to the v2.0.0 milestone Jun 26, 2020
@paddycarver
Copy link
Contributor Author

#476 has more info on this, as well.

@falzm
Copy link

falzm commented Jul 22, 2020

That'd be nice, since it started triggering linting errors all of a sudden... Besides, is there a reason that only the ResourceData.SetPartial() method has been deprecated and not ResourceData.Partial()? From my understanding of #312, both should be.

paddycarver added a commit to hashicorp/terraform-website that referenced this issue Jul 30, 2020
We missed some sections and have some new sections that needed to be
added to the upgrade guide to v2 of the SDK.

Closes hashicorp/terraform-plugin-sdk#493.

Closes hashicorp/terraform-plugin-sdk#492.

Closes hashicorp/terraform-plugin-sdk#487.

Closes hashicorp/terraform-plugin-sdk#484.
@ghost
Copy link

ghost commented Aug 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants