Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: fix unknown value validation bug #1047

Merged
merged 3 commits into from
Sep 2, 2022
Merged

schema: fix unknown value validation bug #1047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f64ef7
schema: fix unknown value validation bug
kmoe Sep 2, 2022
db2b35b
unknown + deprecated should not generate diag
kmoe Sep 2, 2022
d7e1fd9
Merge branch 'main' into kmoe/deprecated-unknown-diag
bflad Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions helper/schema/schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1735,15 +1735,7 @@ func (m schemaMap) validate(
// The SDK has to allow the unknown value through initially, so that
// Required fields set via an interpolated value are accepted.
if !isWhollyKnown(raw) {
if schema.Deprecated != "" {
return append(diags, diag.Diagnostic{
Severity: diag.Warning,
Summary: "Argument is deprecated",
Detail: schema.Deprecated,
AttributePath: path,
})
}
return diags
return nil
}

err = validateConflictingAttributes(k, schema, c)
Expand Down
5 changes: 1 addition & 4 deletions helper/schema/schema_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5792,10 +5792,7 @@ func TestSchemaMap_Validate(t *testing.T) {
Config: map[string]interface{}{
"old_news": hcl2shim.UnknownVariableValue,
},

Warnings: []string{
"Warning: Argument is deprecated: please use 'new_news' instead",
},
Err: false,
},

"Required sub-resource field": {
Expand Down