Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema/ExactlyOneOf: Fix handling of unknowns in complex types #287

Merged
merged 3 commits into from
Jan 8, 2020
Merged

schema/ExactlyOneOf: Fix handling of unknowns in complex types #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d49c14b
schema/ExactlyOneOf: Fix handling of unknowns in complex types
radeksimko Jan 7, 2020
4518ddc
add test for ConflictsWith
radeksimko Jan 7, 2020
f85f24c
add test for AtLeastOneOf
radeksimko Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions helper/schema/schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1508,13 +1508,13 @@ func validateExactlyOneAttribute(
specified := make([]string, 0)
unknownVariableValueCount := 0
for _, exactlyOneOfKey := range allKeys {
if raw, ok := c.Get(exactlyOneOfKey); ok {
if raw == hcl2shim.UnknownVariableValue {
// This aims to do a best effort check that at least one value is specified whether
// it's known or not.
unknownVariableValueCount++
continue
}
if c.IsComputed(exactlyOneOfKey) {
unknownVariableValueCount++
continue
}

_, ok := c.Get(exactlyOneOfKey)
if ok {
specified = append(specified, exactlyOneOfKey)
}
}
Expand Down
Loading