Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/plugintest: Output saved plans in human readable format #605

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 3, 2020

Reference: #578
Closes #604

Restores v2.0.3 behavior and renames the function slightly for additional clarity on its intent.

Previously with consistently failing provider check:

=== CONT  TestAccAWSDmsReplicationTask_basic
TestAccAWSDmsReplicationTask_basic: resource_aws_dms_replication_task_test.go:18: Step 1/3 error: After applying this test step, the plan was not empty.
stdout:
{"format_version":"0.1","terraform_version":"0.12.29","planned_values":{"root_module":{"resources":[{"address":"aws_dms_endpoint.dms_endpoint_source","mode":"managed","type":"aws_dms_endpoint","name":"dms_endpoint_source","provider_name":"aws","schema_version":0,"values":{"certificate_arn":"","database_name":"tf-test-dms-db","elasticsearch_settings":[],"endpoint_arn":"arn:aws:dms:us-west-2:*******:endpoint:JIH35DGCIVAHLVA4L3H7S2QJKNIMW5K2X7LDSAY","endpoint_id":"tf-test-dms-endpoint-source-0qkeppvm","endpoint_type":"source","engine_name":"aurora","extra_connection_attributes":"","id":"tf-test-dms-endpoint-source-0qkeppvm","kafka_settings":[],"kinesis_settings":[],"kms_key_arn":"arn:aws:kms:us-west-2:*******:key/f5709827-76e0-4544-b2ec-9d09d1138bb1","mongodb_settings":[],"password":"tftest","port":3306,"s3_settings":[],"server_name":"tf-test-cluster.cluster-xxxxxxx.us-west-2.rds.amazonaws.com","service_access_role":null,"ssl_mode":"none","tags":null,"username":"tftest"}},{"address":"aws_dms_endpoint.dms_endpoint_target","mode":"managed","type":"aws_dms_endpoint","name":"dms_endpoint_target","provider_name":"aws","schema_version":0,"values":{"certificate_arn":"","database_name":"tf-test-dms-db","elasticsearch_settings":[],"endpoint_arn":"arn:...........

Now with local Go Module replace directive:

=== CONT  TestAccAWSDmsReplicationTask_basic
    resource_aws_dms_replication_task_test.go:18: Step 1/3 error: After applying this test step, the plan was not empty.
        stdout:

        An execution plan has been generated and is shown below.
        Resource actions are indicated with the following symbols:
          ~ update in-place

        Terraform will perform the following actions:

          # aws_dms_replication_task.dms_replication_task will be updated in-place
          ~ resource "aws_dms_replication_task" "dms_replication_task" {
                id                        = "tf-test-dms-replication-task-qsk63z02"
                migration_type            = "full-load"
                replication_instance_arn  = "arn:aws:dms:us-west-2:--OMITTED--:rep:AZCTZFYYTBQUNMNFP3LDR3A5RAC44QTLT36UC4I"
                replication_task_arn      = "arn:aws:dms:us-west-2:--OMITTED--:task:YS3DREABEI2X4KW46QHESNSZIBOAZXU4WLIPH5I"
                replication_task_id       = "tf-test-dms-replication-task-qsk63z02"
              ~ replication_task_settings = jsonencode(
                  ~ {

Reference: hashicorp#578
Reference: hashicorp#604

Restores v2.0.3 behavior and renames the function slightly for additional clarity on its intent.

Previously with consistently failing provider check:

```
=== CONT  TestAccAWSDmsReplicationTask_basic
TestAccAWSDmsReplicationTask_basic: resource_aws_dms_replication_task_test.go:18: Step 1/3 error: After applying this test step, the plan was not empty.
stdout:
{"format_version":"0.1","terraform_version":"0.12.29","planned_values":{"root_module":{"resources":[{"address":"aws_dms_endpoint.dms_endpoint_source","mode":"managed","type":"aws_dms_endpoint","name":"dms_endpoint_source","provider_name":"aws","schema_version":0,"values":{"certificate_arn":"","database_name":"tf-test-dms-db","elasticsearch_settings":[],"endpoint_arn":"arn:aws:dms:us-west-2:*******:endpoint:JIH35DGCIVAHLVA4L3H7S2QJKNIMW5K2X7LDSAY","endpoint_id":"tf-test-dms-endpoint-source-0qkeppvm","endpoint_type":"source","engine_name":"aurora","extra_connection_attributes":"","id":"tf-test-dms-endpoint-source-0qkeppvm","kafka_settings":[],"kinesis_settings":[],"kms_key_arn":"arn:aws:kms:us-west-2:*******:key/f5709827-76e0-4544-b2ec-9d09d1138bb1","mongodb_settings":[],"password":"tftest","port":3306,"s3_settings":[],"server_name":"tf-test-cluster.cluster-xxxxxxx.us-west-2.rds.amazonaws.com","service_access_role":null,"ssl_mode":"none","tags":null,"username":"tftest"}},{"address":"aws_dms_endpoint.dms_endpoint_target","mode":"managed","type":"aws_dms_endpoint","name":"dms_endpoint_target","provider_name":"aws","schema_version":0,"values":{"certificate_arn":"","database_name":"tf-test-dms-db","elasticsearch_settings":[],"endpoint_arn":"arn:...........
```

Now with local Go Module replace directive:

```
=== CONT  TestAccAWSDmsReplicationTask_basic
    resource_aws_dms_replication_task_test.go:18: Step 1/3 error: After applying this test step, the plan was not empty.
        stdout:

        An execution plan has been generated and is shown below.
        Resource actions are indicated with the following symbols:
          ~ update in-place

        Terraform will perform the following actions:

          # aws_dms_replication_task.dms_replication_task will be updated in-place
          ~ resource "aws_dms_replication_task" "dms_replication_task" {
                id                        = "tf-test-dms-replication-task-qsk63z02"
                migration_type            = "full-load"
                replication_instance_arn  = "arn:aws:dms:us-west-2:--OMITTED--:rep:AZCTZFYYTBQUNMNFP3LDR3A5RAC44QTLT36UC4I"
                replication_task_arn      = "arn:aws:dms:us-west-2:--OMITTED--:task:YS3DREABEI2X4KW46QHESNSZIBOAZXU4WLIPH5I"
                replication_task_id       = "tf-test-dms-replication-task-qsk63z02"
              ~ replication_task_settings = jsonencode(
                  ~ {
```
@paddycarver paddycarver merged commit 25c7def into hashicorp:master Oct 6, 2020
@bflad bflad deleted the b-SavedPlanStdout branch October 13, 2020 13:45
@ghost
Copy link

ghost commented Nov 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acceptance Testing Returning JSON Plan Difference After Apply (regression between v2.0.3 and HEAD)
2 participants