Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Check function examples with statecheck package implementations #363

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

austinvalle
Copy link
Member

Mentioned in a recent GH issue, our docs still reference the Check function in all the existing "best practice" examples.

I went through and just adjusted them to match the current recommendation to use the statecheck package. I omitted the custom state check implementations, mostly because some can be replaced by upcoming functionality in #330, but also because we should probably rewrite a good chunk of this documentation.

This is just to point provider developers in the general direction of statecheck before we deprecate the Check function.

@austinvalle austinvalle added the documentation Improvements or additions to documentation label Aug 2, 2024
@austinvalle austinvalle added this to the v1.10.0 milestone Aug 2, 2024
@austinvalle austinvalle requested a review from a team as a code owner August 2, 2024 20:26
@austinvalle austinvalle merged commit 4910d52 into main Aug 6, 2024
3 checks passed
@austinvalle austinvalle deleted the av/testing-docs branch August 6, 2024 16:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants