Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 70 local + add provider examples in documentation #80

Merged
merged 11 commits into from
Feb 8, 2021

Conversation

jpatigny
Copy link
Contributor

@jpatigny jpatigny commented Jan 31, 2021

Description

  • Implement the possibility to run powershell commands locally (not via winrm) if the operating system is windows and no credentials are set in the provider configuration

  • Add examples in documentation regarding provider configuration

(Once again I apologies for not adding tests, I'm still not familiar with how to implement those.)

References

#70

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ghost ghost added the size/XL label Jan 31, 2021
Copy link
Contributor

@koikonom koikonom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@koikonom koikonom merged commit a1b5b68 into hashicorp:main Feb 8, 2021
@ghost
Copy link

ghost commented Mar 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants