Merge pull request #38658 from hashicorp/b/smithy_json_type

b/smithy json type expands to any type
hashicorp · Aug 2, 2024 · 00d5f3b · 00d5f3b
2 parents 53bd91a + bcaddc6
commit 00d5f3b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/internal/framework/types/smithy_json.go b/internal/framework/types/smithy_json.go
@@ -125,7 +125,7 @@ func (v SmithyJSON[T]) ValueInterface() (T, diag.Diagnostics) {
 		return zero, diags
 	}
 
-	var data map[string]any
+	var data any
 	err := json.Unmarshal([]byte(v.ValueString()), &data)
 
 	if err != nil {

diff --git a/internal/framework/types/smithy_json_test.go b/internal/framework/types/smithy_json_test.go
@@ -142,6 +142,12 @@ func TestSmithyJSONValueInterface(t *testing.T) {
 				},
 			},
 		},
+		"valid SmithyJSON slice": { // lintignore:AWSAT003,AWSAT005
+			val: fwtypes.SmithyJSONValue[smithyjson.JSONStringer](`["value1","value"]`, newTestJSONDocument), // lintignore:AWSAT003,AWSAT005
+			expected: &testJSONDocument{
+				Value: []any{"value1", "value"},
+			},
+		},
 		"invalid SmithyJSON": {
 			val:         fwtypes.SmithyJSONValue[smithyjson.JSONStringer]("not ok", newTestJSONDocument), // lintignore:AWSAT003,AWSAT005
 			expectError: true,