Fix and enable tfproviderlint S023 check (#12781)

hashicorp · Apr 15, 2020 · 0c3c31f · 0c3c31f
1 parent e73ee3d
commit 0c3c31f
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 5 deletions.
diff --git a/GNUmakefile b/GNUmakefile
@@ -93,6 +93,7 @@ lint:
 		-S019 \
 		-S020 \
 		-S021 \
+		-S023 \
 		-S024 \
 		-S025 \
 		-S026 \

diff --git a/aws/resource_aws_db_instance.go b/aws/resource_aws_db_instance.go
@@ -380,7 +380,6 @@ func resourceAwsDbInstance() *schema.Resource {
 				Type:     schema.TypeString,
 				Optional: true,
 				ForceNew: true,
-				Elem:     &schema.Schema{Type: schema.TypeString},
 			},
 
 			"auto_minor_version_upgrade": {

diff --git a/aws/resource_aws_db_instance_migrate.go b/aws/resource_aws_db_instance_migrate.go
@@ -283,7 +283,6 @@ func resourceAwsDbInstanceResourceV0() *schema.Resource {
 				Type:     schema.TypeString,
 				Optional: true,
 				ForceNew: true,
-				Elem:     &schema.Schema{Type: schema.TypeString},
 			},
 
 			"auto_minor_version_upgrade": {

diff --git a/aws/resource_aws_docdb_cluster.go b/aws/resource_aws_docdb_cluster.go
@@ -160,7 +160,6 @@ func resourceAwsDocDBCluster() *schema.Resource {
 			"snapshot_identifier": {
 				Type:     schema.TypeString,
 				Optional: true,
-				Elem:     &schema.Schema{Type: schema.TypeString},
 			},
 
 			"port": {

diff --git a/aws/resource_aws_neptune_cluster.go b/aws/resource_aws_neptune_cluster.go
@@ -244,7 +244,6 @@ func resourceAwsNeptuneCluster() *schema.Resource {
 			"snapshot_identifier": {
 				Type:     schema.TypeString,
 				Optional: true,
-				Elem:     &schema.Schema{Type: schema.TypeString},
 			},
 
 			"tags": tagsSchema(),

diff --git a/aws/resource_aws_rds_cluster.go b/aws/resource_aws_rds_cluster.go
@@ -299,7 +299,6 @@ func resourceAwsRDSCluster() *schema.Resource {
 			"snapshot_identifier": {
 				Type:     schema.TypeString,
 				Optional: true,
-				Elem:     &schema.Schema{Type: schema.TypeString},
 			},
 
 			"port": {
-Original file line number
+Diff line change
@@ Expand Up / @@ -93,6 +93,7 @@ lint: @@
     		-S019 \
     		-S020 \
     		-S021 \
+    		-S023 \
     		-S024 \
     		-S025 \
     		-S026 \
@@ Expand Down @@