Merge pull request #10807 from gordonbondon/instance-launch-template

r/aws_instance: Add support for launch template
hashicorp · Jul 21, 2021 · 27eba3b · 27eba3b
2 parents 209ef79 + af1c082
commit 27eba3b
Show file tree

Hide file tree

Showing 8 changed files with 781 additions and 87 deletions.
diff --git a/.changelog/10807.txt b/.changelog/10807.txt
@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_instance: Add support for configuration with Launch Template
+```
diff --git a/aws/resource_aws_autoscaling_group.go b/aws/resource_aws_autoscaling_group.go
@@ -687,11 +687,7 @@ func resourceAwsAutoscalingGroupCreate(d *schema.ResourceData, meta interface{})
 	}
 
 	if v, ok := d.GetOk("launch_template"); ok {
-		var err error
-		createOpts.LaunchTemplate, err = expandLaunchTemplateSpecification(v.([]interface{}))
-		if err != nil {
-			return err
-		}
+		createOpts.LaunchTemplate = expandLaunchTemplateSpecification(v.([]interface{}))
 	}
 
 	// Availability Zones are optional if VPC Zone Identifier(s) are specified
@@ -1055,7 +1051,7 @@ func resourceAwsAutoscalingGroupUpdate(d *schema.ResourceData, meta interface{})
 
 	if d.HasChange("launch_template") {
 		if v, ok := d.GetOk("launch_template"); ok && len(v.([]interface{})) > 0 {
-			opts.LaunchTemplate, _ = expandLaunchTemplateSpecification(v.([]interface{}))
+			opts.LaunchTemplate = expandLaunchTemplateSpecification(v.([]interface{}))
 		}
 		shouldRefreshInstances = true
 	}
@@ -1891,15 +1887,15 @@ func expandAutoScalingInstancesDistribution(l []interface{}) *autoscaling.Instan
 	return instancesDistribution
 }
 
-func expandAutoScalingLaunchTemplate(l []interface{}) *autoscaling.LaunchTemplate {
+func expandMixedInstancesLaunchTemplate(l []interface{}) *autoscaling.LaunchTemplate {
 	if len(l) == 0 || l[0] == nil {
 		return nil
 	}
 
 	m := l[0].(map[string]interface{})
 
 	launchTemplate := &autoscaling.LaunchTemplate{
-		LaunchTemplateSpecification: expandAutoScalingLaunchTemplateSpecification(m["launch_template_specification"].([]interface{})),
+		LaunchTemplateSpecification: expandMixedInstancesLaunchTemplateSpecification(m["launch_template_specification"].([]interface{})),
 	}
 
 	if v, ok := m["override"]; ok {
@@ -1934,7 +1930,7 @@ func expandAutoScalingLaunchTemplateOverride(m map[string]interface{}) *autoscal
 	}
 
 	if v, ok := m["launch_template_specification"]; ok && v.([]interface{}) != nil {
-		launchTemplateOverrides.LaunchTemplateSpecification = expandAutoScalingLaunchTemplateSpecification(m["launch_template_specification"].([]interface{}))
+		launchTemplateOverrides.LaunchTemplateSpecification = expandMixedInstancesLaunchTemplateSpecification(m["launch_template_specification"].([]interface{}))
 	}
 
 	if v, ok := m["weighted_capacity"]; ok && v.(string) != "" {
@@ -1944,7 +1940,7 @@ func expandAutoScalingLaunchTemplateOverride(m map[string]interface{}) *autoscal
 	return launchTemplateOverrides
 }
 
-func expandAutoScalingLaunchTemplateSpecification(l []interface{}) *autoscaling.LaunchTemplateSpecification {
+func expandMixedInstancesLaunchTemplateSpecification(l []interface{}) *autoscaling.LaunchTemplateSpecification {
 	launchTemplateSpecification := &autoscaling.LaunchTemplateSpecification{}
 
 	if len(l) == 0 || l[0] == nil {
@@ -1979,7 +1975,7 @@ func expandAutoScalingMixedInstancesPolicy(l []interface{}) *autoscaling.MixedIn
 	m := l[0].(map[string]interface{})
 
 	mixedInstancesPolicy := &autoscaling.MixedInstancesPolicy{
-		LaunchTemplate: expandAutoScalingLaunchTemplate(m["launch_template"].([]interface{})),
+		LaunchTemplate: expandMixedInstancesLaunchTemplate(m["launch_template"].([]interface{})),
 	}
 
 	if v, ok := m["instances_distribution"]; ok {
@@ -2294,3 +2290,54 @@ func validateAutoScalingGroupInstanceRefreshTriggerFields(i interface{}, path ct
 
 	return diag.Errorf("'%s' is not a recognized parameter name for aws_autoscaling_group", v)
 }
+
+func expandLaunchTemplateSpecification(specs []interface{}) *autoscaling.LaunchTemplateSpecification {
+	if len(specs) < 1 {
+		return nil
+	}
+
+	spec := specs[0].(map[string]interface{})
+
+	idValue, idOk := spec["id"]
+	nameValue, nameOk := spec["name"]
+
+	result := &autoscaling.LaunchTemplateSpecification{}
+
+	// DescribeAutoScalingGroups returns both name and id but LaunchTemplateSpecification
+	// allows only one of them to be set
+	if idOk && idValue != "" {
+		result.LaunchTemplateId = aws.String(idValue.(string))
+	} else if nameOk && nameValue != "" {
+		result.LaunchTemplateName = aws.String(nameValue.(string))
+	}
+
+	if v, ok := spec["version"]; ok && v != "" {
+		result.Version = aws.String(v.(string))
+	}
+
+	return result
+}
+
+func flattenLaunchTemplateSpecification(lt *autoscaling.LaunchTemplateSpecification) []map[string]interface{} {
+	if lt == nil {
+		return []map[string]interface{}{}
+	}
+
+	attrs := map[string]interface{}{}
+	result := make([]map[string]interface{}, 0)
+
+	// id and name are always returned by DescribeAutoscalingGroups
+	attrs["id"] = aws.StringValue(lt.LaunchTemplateId)
+	attrs["name"] = aws.StringValue(lt.LaunchTemplateName)
+
+	// version is returned only if it was previously set
+	if lt.Version != nil {
+		attrs["version"] = aws.StringValue(lt.Version)
+	} else {
+		attrs["version"] = nil
+	}
+
+	result = append(result, attrs)
+
+	return result
+}