PR feedback tweaks

hashicorp · Mar 8, 2024 · 3374025 · 3374025
1 parent 594f582
commit 3374025
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 15 deletions.
diff --git a/internal/service/servicecatalogappregistry/application.go b/internal/service/servicecatalogappregistry/application.go
@@ -139,7 +139,6 @@ func (r *resourceApplication) Update(ctx context.Context, req resource.UpdateReq
 
 	if !plan.Name.Equal(state.Name) ||
 		!plan.Description.Equal(state.Description) {
-
 		in := &servicecatalogappregistry.UpdateApplicationInput{
 			Application: aws.String(plan.ID.ValueString()),
 		}
@@ -201,13 +200,6 @@ func (r *resourceApplication) ImportState(ctx context.Context, req resource.Impo
 	resource.ImportStatePassthroughID(ctx, path.Root("id"), req, resp)
 }
 
-const (
-	statusChangePending = "Pending"
-	statusDeleting      = "Deleting"
-	statusNormal        = "Normal"
-	statusUpdated       = "Updated"
-)
-
 func findApplicationByID(ctx context.Context, conn *servicecatalogappregistry.Client, id string) (*servicecatalogappregistry.GetApplicationOutput, error) {
 	in := &servicecatalogappregistry.GetApplicationInput{
 		Application: aws.String(id),

diff --git a/internal/service/servicecatalogappregistry/application_test.go b/internal/service/servicecatalogappregistry/application_test.go
@@ -128,11 +128,8 @@ func testAccCheckApplicationExists(ctx context.Context, name string) resource.Te
 		conn := acctest.Provider.Meta().(*conns.AWSClient).ServiceCatalogAppRegistryClient(ctx)
 
 		_, err := servicecatalogappregistry.FindApplicationByID(ctx, conn, rs.Primary.ID)
-		if err != nil {
-			return err
-		}
 
-		return nil
+		return err
 	}
 }
 

diff --git a/website/docs/r/servicecatalogappregistry_application.html.markdown b/website/docs/r/servicecatalogappregistry_application.html.markdown
@@ -1,15 +1,15 @@
 ---
-subcategory: "Service Catalog"
+subcategory: "Service Catalog AppRegistry"
 layout: "aws"
 page_title: "AWS: aws_servicecatalogappregistry_application"
 description: |-
   Terraform resource for managing an AWS Service Catalog AppRegistry Application.
 ---
 # Resource: aws_servicecatalogappregistry_application
 
-Terraform resource for managing an AWS Service Catalog AppRegistry Application. 
+Terraform resource for managing an AWS Service Catalog AppRegistry Application.
 
-~> **NOTE: ** An AWS Service Catalog AppRegistry Application is also available in the AWS Console as "MyApplications"
+~> **NOTE:** An AWS Service Catalog AppRegistry Application is also available in the AWS Console as "MyApplications"
 
 ## Example Usage