Merge pull request #32941 from hashicorp/b-elbv2-dupe-name

elbv2/lb: Check for duplicate name
hashicorp · Aug 10, 2023 · 5e0fbe7 · 5e0fbe7
2 parents 4955f25 + dc9ae76
commit 5e0fbe7
Show file tree

Hide file tree

Showing 3 changed files with 369 additions and 174 deletions.
diff --git a/.changelog/32941.txt b/.changelog/32941.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_lb: Fix to avoid creating a load balancer with same name as an existing load balancer
+```
diff --git a/internal/service/elbv2/load_balancer.go b/internal/service/elbv2/load_balancer.go
@@ -316,6 +316,19 @@ func resourceLoadBalancerCreate(ctx context.Context, d *schema.ResourceData, met
  } else {
  name = id.PrefixedUniqueId("tf-lb-")
  }
+
+ exist, err := FindLoadBalancer(ctx, conn, &elbv2.DescribeLoadBalancersInput{
+ Names: aws.StringSlice([]string{name}),
+ })
+
+ if err != nil && !tfresource.NotFound(err) {
+ return sdkdiag.AppendErrorf(diags, "reading ELBv2 Load Balancer (%s): %s", name, err)
+ }
+
+ if exist != nil {
+ return sdkdiag.AppendErrorf(diags, "ELBv2 Target Group (%s) already exists", name)
+ }
+
  d.Set("name", name)
 
  lbType := d.Get("load_balancer_type").(string)