Skip to content

Commit

Permalink
resource/aws_route53_zone: Support multiple vpc associations, depreca…
Browse files Browse the repository at this point in the history
…te vpc_id and vpc_region, and enhance acceptance testing

Changes:
* Add `vpc` TypeSet attribute to support exclusive management and import of multiple VPC associations
* Deprecate `vpc_id` and `vpc_region` attributes in favor of `vpc`, adding note to Version 2 Upgrade Guide
* Refactor Create/Read/Update/Delete to return error message context, use AWS Go SDK helpers to prevent panics, always call d.Set(), and use isAWSErr()
* Add acceptance testing for delegation_set_id attribute
* Enhance acceptance testing for tags to test updates
* Migrate _importBasic acceptance test to Import TestStep in all acceptance tests

Output from acceptance testing:

```
--- PASS: TestAccAWSRoute53Zone_basic (73.02s)
--- PASS: TestAccAWSRoute53Zone_VPCRegion (73.44s)
--- PASS: TestAccAWSRoute53Zone_DelegationSetID (76.95s)
--- PASS: TestAccAWSRoute53Zone_Comment (81.43s)
--- PASS: TestAccAWSRoute53Zone_VPCID (82.88s)
--- PASS: TestAccAWSRoute53Zone_multiple (84.98s)
--- PASS: TestAccAWSRoute53Zone_VPC_Single (88.03s)
--- PASS: TestAccAWSRoute53Zone_Tags (91.95s)
--- PASS: TestAccAWSRoute53Zone_VPC_Multiple (140.49s)
--- PASS: TestAccAWSRoute53Zone_VPC_Updates (226.21s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy (249.03s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (249.05s)
```
  • Loading branch information
bflad committed Oct 30, 2018
1 parent 5aaf64f commit 7351b74
Show file tree
Hide file tree
Showing 5 changed files with 872 additions and 281 deletions.
Loading

0 comments on commit 7351b74

Please sign in to comment.