Skip to content

Commit

Permalink
tests/data-source/aws_network_interfaces: Address #5324 pull request …
Browse files Browse the repository at this point in the history
…feedback

* Remove subnet availability_zone to allow for reusability across partitions/regions
* Add aws_network_interface.test1 ordering dependency to filter configuration

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsNetworkInterfaces'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsNetworkInterfaces -timeout 120m
=== RUN   TestAccDataSourceAwsNetworkInterfaces_Filter
--- PASS: TestAccDataSourceAwsNetworkInterfaces_Filter (33.74s)
=== RUN   TestAccDataSourceAwsNetworkInterfaces_Tags
--- PASS: TestAccDataSourceAwsNetworkInterfaces_Tags (33.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	67.570s
  • Loading branch information
bflad committed Jul 25, 2018
1 parent 106fa7b commit 74dbc7c
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions aws/data_source_aws_network_interfaces_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ resource "aws_vpc" "test" {
resource "aws_subnet" "test" {
cidr_block = "10.0.0.0/24"
availability_zone = "us-west-2a"
vpc_id = "${aws_vpc.test.id}"
tags {
Name = "terraform-testacc-eni-data-source-basic-%s"
Expand All @@ -79,7 +78,7 @@ func testAccDataSourceAwsNetworkInterfacesConfig_Filter(rName string) string {
data "aws_network_interfaces" "test" {
filter {
name = "subnet-id"
values = ["${aws_network_interface.test.subnet_id}"]
values = ["${aws_network_interface.test.subnet_id}", "${aws_network_interface.test1.subnet_id}"]
}
}
`
Expand Down

0 comments on commit 74dbc7c

Please sign in to comment.