Skip to content

Commit

Permalink
resource/aws_glue_job: Address PR #10237 feedback
Browse files Browse the repository at this point in the history
Reference: #10237 (review)

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (52.40s)
--- PASS: TestAccAWSGlueJob_Timeout (52.61s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (57.79s)
--- PASS: TestAccAWSGlueJob_Description (61.93s)
--- PASS: TestAccAWSGlueJob_Command (62.62s)
--- PASS: TestAccAWSGlueJob_Basic (72.67s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (74.90s)
--- PASS: TestAccAWSGlueJob_MaxRetries (81.59s)
--- PASS: TestAccAWSGlueJob_GlueVersion (88.02s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (99.31s)
--- PASS: TestAccAWSGlueJob_PythonShell (105.36s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (124.59s)
```

Output from acceptance testing in AWS GovCloud (US) (new test failure acceptable in this partition):

```
--- FAIL: TestAccAWSGlueJob_GlueVersion (34.67s)
    testing.go:615: Step 0 error: Check failed: Check 2/2 error: aws_glue_job.test: Attribute 'glue_version' expected "0.9", got ""
--- PASS: TestAccAWSGlueJob_Command (51.17s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (67.58s)
--- PASS: TestAccAWSGlueJob_MaxRetries (68.45s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (75.77s)
--- PASS: TestAccAWSGlueJob_PythonShell (81.86s)
--- PASS: TestAccAWSGlueJob_Description (86.03s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (95.51s)
--- PASS: TestAccAWSGlueJob_Timeout (103.41s)
--- PASS: TestAccAWSGlueJob_Basic (120.65s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (134.29s)
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (143.32s)
```
  • Loading branch information
bflad committed Oct 30, 2019
1 parent 1bb2d5b commit 8631489
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions aws/resource_aws_glue_job.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ func resourceAwsGlueJob() *schema.Resource {
"glue_version": {
Type: schema.TypeString,
Optional: true,
Computed: true,
},
"execution_property": {
Type: schema.TypeList,
Expand Down
4 changes: 2 additions & 2 deletions website/docs/r/glue_job.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,14 @@ be removed in future releases, please use `max_capacity` instead.
* `default_arguments` – (Optional) The map of default arguments for this job. You can specify arguments here that your own job-execution script consumes, as well as arguments that AWS Glue itself consumes. For information about how to specify and consume your own Job arguments, see the [Calling AWS Glue APIs in Python](http://docs.aws.amazon.com/glue/latest/dg/aws-glue-programming-python-calling.html) topic in the developer guide. For information about the key-value pairs that AWS Glue consumes to set up your job, see the [Special Parameters Used by AWS Glue](http://docs.aws.amazon.com/glue/latest/dg/aws-glue-programming-python-glue-arguments.html) topic in the developer guide.
* `description` – (Optional) Description of the job.
* `execution_property` – (Optional) Execution property of the job. Defined below.
* `glue_version` - (Optional) The version of glue to use, for example "1.0". For information about available versions, see the [AWS Glue Release Notes](https://docs.aws.amazon.com/glue/latest/dg/release-notes.html).
* `max_capacity` – (Optional) The maximum number of AWS Glue data processing units (DPUs) that can be allocated when this job runs.
* `max_retries` – (Optional) The maximum number of times to retry this job if it fails.
* `name` – (Required) The name you assign to this job. It must be unique in your account.
* `role_arn` – (Required) The ARN of the IAM role associated with this job.
* `timeout` – (Optional) The job timeout in minutes. The default is 2880 minutes (48 hours).
* `security_configuration` - (Optional) The name of the Security Configuration to be associated with the job.
* `glue_version` - (Optional) The version of glue to use, for example "1.0". For information about available versionse see [AWS Glue Release Notes](https://docs.aws.amazon.com/glue/latest/dg/release-notes.html).


### command Argument Reference

* `name` - (Optional) The name of the job command. Defaults to `glueetl`
Expand Down

0 comments on commit 8631489

Please sign in to comment.