r/s3_bucket_logging: new resource

hashicorp · Feb 3, 2022 · a85f96d · a85f96d
1 parent 5cbf147
commit a85f96d
Show file tree

Hide file tree

Showing 6 changed files with 1,019 additions and 2 deletions.
diff --git a/.changelog/22608.txt b/.changelog/22608.txt
@@ -0,0 +1,3 @@
+```release-note:new-resource
+aws_s3_bucket_logging
+```
diff --git a/internal/provider/provider.go b/internal/provider/provider.go
@@ -1625,6 +1625,7 @@ func Provider() *schema.Provider {
 			"aws_s3_bucket_cors_configuration":                s3.ResourceBucketCorsConfiguration(),
 			"aws_s3_bucket_intelligent_tiering_configuration": s3.ResourceBucketIntelligentTieringConfiguration(),
 			"aws_s3_bucket_inventory":                         s3.ResourceBucketInventory(),
+			"aws_s3_bucket_logging":                           s3.ResourceBucketLogging(),
 			"aws_s3_bucket_metric":                            s3.ResourceBucketMetric(),
 			"aws_s3_bucket_notification":                      s3.ResourceBucketNotification(),
 			"aws_s3_bucket_ownership_controls":                s3.ResourceBucketOwnershipControls(),

diff --git a/internal/service/s3/bucket.go b/internal/service/s3/bucket.go
@@ -806,7 +806,7 @@ func resourceBucketUpdate(d *schema.ResourceData, meta interface{}) error {
 	}
 
 	if d.HasChange("logging") {
-		if err := resourceBucketLoggingUpdate(conn, d); err != nil {
+		if err := resourceBucketInternalLoggingUpdate(conn, d); err != nil {
 			return err
 		}
 	}
@@ -1868,7 +1868,7 @@ func resourceBucketInternalVersioningUpdate(conn *s3.S3, bucket string, versioni
 	return nil
 }
 
-func resourceBucketLoggingUpdate(conn *s3.S3, d *schema.ResourceData) error {
+func resourceBucketInternalLoggingUpdate(conn *s3.S3, d *schema.ResourceData) error {
 	logging := d.Get("logging").(*schema.Set).List()
 	bucket := d.Get("bucket").(string)
 	loggingStatus := &s3.BucketLoggingStatus{}