Skip to content

Commit

Permalink
code review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
breathingdust committed Oct 30, 2020
1 parent 0cd6eb7 commit bd73c44
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 35 deletions.
54 changes: 27 additions & 27 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,42 +1,42 @@
# Default owner for all pull requests
* @hashicorp/aws-provider
* @hashicorp/terraform-aws

# Service specific owners
/aws/*apigatewayv2* @ewbankkit @hashicorp/aws-provider
/website/**/apigatewayv2* @ewbankkit @hashicorp/aws-provider
/aws/*apigatewayv2* @ewbankkit @hashicorp/terraform-aws
/website/**/apigatewayv2* @ewbankkit @hashicorp/terraform-aws

/aws/*appmesh* @ewbankkit @hashicorp/aws-provider
/website/**/appmesh* @ewbankkit @hashicorp/aws-provider
/aws/*appmesh* @ewbankkit @hashicorp/terraform-aws
/website/**/appmesh* @ewbankkit @hashicorp/terraform-aws

/aws/*backup* @ewbankkit @hashicorp/aws-provider
/website/**/backup* @ewbankkit @hashicorp/aws-provider
/aws/*backup* @ewbankkit @hashicorp/terraform-aws
/website/**/backup* @ewbankkit @hashicorp/terraform-aws

/aws/*_aws_codeartifact_*.go @DrFaust92 @hashicorp/aws-provider
/website/**/codeartifact* @DrFaust92 @hashicorp/aws-provider
/aws/*_aws_codeartifact_*.go @DrFaust92 @hashicorp/terraform-aws
/website/**/codeartifact* @DrFaust92 @hashicorp/terraform-aws

/aws/*_aws_fsx_*.go @DrFaust92 @hashicorp/aws-provider
/website/**/fsx* @DrFaust92 @hashicorp/aws-provider
/aws/*_aws_fsx_*.go @DrFaust92 @hashicorp/terraform-aws
/website/**/fsx* @DrFaust92 @hashicorp/terraform-aws

/aws/*globalaccelerator* @ewbankkit @hashicorp/aws-provider
/website/**/globalaccelerator* @ewbankkit @hashicorp/aws-provider
/aws/*globalaccelerator* @ewbankkit @hashicorp/terraform-aws
/website/**/globalaccelerator* @ewbankkit @hashicorp/terraform-aws

/aws/*_aws_glue_*.go @DrFaust92 @hashicorp/aws-provider
/website/**/glue* @DrFaust92 @hashicorp/aws-provider
/aws/*_aws_glue_*.go @DrFaust92 @hashicorp/terraform-aws
/website/**/glue* @DrFaust92 @hashicorp/terraform-aws

/aws/*kinesis_analytics* @ewbankkit @hashicorp/aws-provider
/website/**/kinesis_analytics* @ewbankkit @hashicorp/aws-provider
/aws/*kinesis_analytics* @ewbankkit @hashicorp/terraform-aws
/website/**/kinesis_analytics* @ewbankkit @hashicorp/terraform-aws

/aws/*kinesisanalyticsv2* @ewbankkit @hashicorp/aws-provider
/website/**/kinesisanalyticsv2* @ewbankkit @hashicorp/aws-provider
/aws/*kinesisanalyticsv2* @ewbankkit @hashicorp/terraform-aws
/website/**/kinesisanalyticsv2* @ewbankkit @hashicorp/terraform-aws

/aws/*route53_resolver* @ewbankkit @hashicorp/aws-provider
/website/**/route53_resolver* @ewbankkit @hashicorp/aws-provider
/aws/*route53_resolver* @ewbankkit @hashicorp/terraform-aws
/website/**/route53_resolver* @ewbankkit @hashicorp/terraform-aws

/aws/*_aws_storagegateway_*.go @DrFaust92 @hashicorp/aws-provider
/website/**/storagegateway* @DrFaust92 @hashicorp/aws-provider
/aws/*_aws_storagegateway_*.go @DrFaust92 @hashicorp/terraform-aws
/website/**/storagegateway* @DrFaust92 @hashicorp/terraform-aws

/aws/*_aws_sagemaker_*.go @DrFaust92 @hashicorp/aws-provider
/website/**/sagemaker* @DrFaust92 @hashicorp/aws-provider
/aws/*_aws_sagemaker_*.go @DrFaust92 @hashicorp/terraform-aws
/website/**/sagemaker* @DrFaust92 @hashicorp/terraform-aws

/aws/*_aws_workspaces_*.go @Tensho @hashicorp/aws-provider
/website/**/workspaces* @Tensho @hashicorp/aws-provider
/aws/*_aws_workspaces_*.go @Tensho @hashicorp/terraform-aws
/website/**/workspaces* @Tensho @hashicorp/terraform-aws
7 changes: 0 additions & 7 deletions .hashibot.hcl
Original file line number Diff line number Diff line change
Expand Up @@ -1530,10 +1530,3 @@ behavior "pull_request_size_labeler" "size" {
}
}
}

behavior "pull_request_path_labeler" "cross_provider_labels" {
label_map = {
"documentation" = ["website/**/*"]
"dependencies" = ["vendor/**/*"]
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit bd73c44

Please sign in to comment.