tests/provider: Use Go Modules for tool versioning

References:

* #7993
* https://github.com/go-modules-by-example/index/blob/master/010_tools/README.md

This installation method allows us to control tooling versions via Go Modules instead of receiving unexpected updates from latest upstream code. We prefer this method over installing binaries from shell scripts and needing to manually manage tooling versions in other ways.

We start by pinning golangci-lint@v1.15.0 and misspell@v0.3.4.

GNUmakefile

@@ -35,8 +35,8 @@ lint:
 	@golangci-lint run ./$(PKG_NAME)
 
 tools:
-	GO111MODULE=off go get -u github.com/client9/misspell/cmd/misspell
-	GO111MODULE=off go get -u github.com/golangci/golangci-lint/cmd/golangci-lint
+	GO111MODULE=on go install github.com/client9/misspell/cmd/misspell
+	GO111MODULE=on go install github.com/golangci/golangci-lint/cmd/golangci-lint
 
 test-compile:
 	@if [ "$(TEST)" = "./..." ]; then \

go.mod

@@ -9,9 +9,14 @@ require (
 	github.com/bgentry/speakeasy v0.1.0 // indirect
 	github.com/blang/semver v3.5.1+incompatible // indirect
 	github.com/boombuler/barcode v0.0.0-20180809052337-34fff276c74e // indirect
+	github.com/client9/misspell v0.3.4
+	github.com/go-toolsmith/pkgload v0.0.0-20181120203407-5122569a890b // indirect
 	github.com/gogo/protobuf v1.2.0 // indirect
 	github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b // indirect
 	github.com/golang/snappy v0.0.0-20180518054509-2e65f85255db // indirect
+	github.com/golangci/go-tools v0.0.0-20190124090046-35a9f45a5db0 // indirect
+	github.com/golangci/golangci-lint v1.15.0
+	github.com/golangci/gosec v0.0.0-20180901114220-8afd9cbb6cfb // indirect
 	github.com/google/gofuzz v0.0.0-20170612174753-24818f796faf // indirect
 	github.com/hashicorp/aws-sdk-go-base v0.3.0
 	github.com/hashicorp/go-cleanhttp v0.5.0

tools.go

@@ -0,0 +1,8 @@
+// +build tools
+
+package main
+
+import (
+	_ "github.com/client9/misspell/cmd/misspell"
+	_ "github.com/golangci/golangci-lint/cmd/golangci-lint"
+)