Merge pull request #30452 from mschwrz/b-remove-ignore-headers-row

Removed deprecated field ignore_headers_row
hashicorp · May 3, 2023 · fa32db1 · fa32db1
2 parents cf51f5d + 5fe01fd
commit fa32db1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/.changelog/30452.txt b/.changelog/30452.txt
@@ -0,0 +1,3 @@
+```release-note:breaking-change
+resource/aws_dms_endpoint: `s3_settings.ignore_headers_row` has been removed
+```
diff --git a/internal/service/dms/endpoint.go b/internal/service/dms/endpoint.go
@@ -567,12 +567,6 @@ func ResourceEndpoint() *schema.Resource {
 							Optional: true,
 							Default:  "",
 						},
-						"ignore_headers_row": {
-							Type:         schema.TypeInt,
-							Optional:     true,
-							ValidateFunc: validation.IntInSlice([]int{0, 1}),
-							Description:  "This setting has no effect, is deprecated, and will be removed in a future version",
-						},
 						"ignore_header_rows": {
 							Type:         schema.TypeInt,
 							Optional:     true,

diff --git a/website/docs/r/dms_endpoint.html.markdown b/website/docs/r/dms_endpoint.html.markdown
@@ -179,7 +179,6 @@ The following arguments are optional:
 * `encryption_mode` - (Optional) Server-side encryption mode that you want to encrypt your .csv or .parquet object files copied to S3. Valid values are `SSE_S3` and `SSE_KMS`. Default is `SSE_S3`.
 * `external_table_definition` - (Optional) JSON document that describes how AWS DMS should interpret the data.
 * `ignore_header_rows` - (Optional) When this value is set to `1`, DMS ignores the first row header in a .csv file. Default is `0`.
-* `ignore_headers_row` - (Optional) Deprecated. This setting has no effect. Will be removed in a future version.
 * `include_op_for_full_load` - (Optional) Whether to enable a full load to write INSERT operations to the .csv output files only to indicate how the rows were added to the source database. Default is `false`.
 * `max_file_size` - (Optional) Maximum size (in KB) of any .csv file to be created while migrating to an S3 target during full load. Valid values are from `1` to `1048576`. Default is `1048576` (1 GB).
 * `parquet_timestamp_in_millisecond` - (Optional) - Specifies the precision of any TIMESTAMP column values written to an S3 object file in .parquet format. Default is `false`.