Fix providerlint AWSAT003.

hashicorp · Aug 15, 2024 · fc2d2cb · fc2d2cb
1 parent 440196b
commit fc2d2cb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/internal/service/ecs/container_definitions.go b/internal/service/ecs/container_definitions.go
@@ -54,13 +54,13 @@ func (cd containerDefinitions) reduce(isAWSVPC bool) {
 	// Compact any sparse lists.
 	cd.compactArrays()
 
+	// Deal with special fields which have defaults.
+	// See https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html#container_definitions.
 	for i, def := range cd {
-		// Deal with special fields which have defaults.
 		if def.Essential == nil {
 			cd[i].Essential = aws.Bool(true)
 		}
-		// Replace nil HealthCheck values with default values. For each property, the default value can be found
-		// in the doc comment for this property.
+
 		if hc := def.HealthCheck; hc != nil {
 			if hc.Interval == nil {
 				hc.Interval = aws.Int32(30)
@@ -72,6 +72,7 @@ func (cd containerDefinitions) reduce(isAWSVPC bool) {
 				hc.Timeout = aws.Int32(5)
 			}
 		}
+
 		for j, pm := range def.PortMappings {
 			if pm.Protocol == awstypes.TransportProtocolTcp {
 				cd[i].PortMappings[j].Protocol = ""

diff --git a/internal/service/ecs/container_definitions_test.go b/internal/service/ecs/container_definitions_test.go
@@ -647,7 +647,7 @@ func TestContainerDefinitionsAreEquivalent_healthCheck(t *testing.T) {
             "logDriver": "awslogs",
             "options": {
                 "awslogs-group": "foo-bar-e196c99",
-                "awslogs-region": "us-east-1",
+                "awslogs-region": "region-1",
                 "awslogs-stream-prefix": "nginx"
             }
         }
@@ -674,7 +674,7 @@ func TestContainerDefinitionsAreEquivalent_healthCheck(t *testing.T) {
             "logDriver": "awslogs",
             "options": {
                 "awslogs-group": "foo-bar-e196c99",
-                "awslogs-region": "us-east-1",
+                "awslogs-region": "region-1",
                 "awslogs-stream-prefix": "nginx"
             }
         },