Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Support for VPC ClassicLink DNS Support #1076

Closed
peimanja opened this issue Jul 7, 2017 · 1 comment · Fixed by #1079
Closed

Request Support for VPC ClassicLink DNS Support #1076

peimanja opened this issue Jul 7, 2017 · 1 comment · Fixed by #1079
Labels
enhancement Requests to existing resources that expand the functionality or scope.

Comments

@peimanja
Copy link

peimanja commented Jul 7, 2017

Terraform Version

v0.9.11

Affected Resource(s)

  • aws_vpc

Terraform Configuration Files

resource "aws_vpc" "main" {
  cidr_block  = "10.0.0.0/16"
  enable_classiclink  = true
  enable_dns_classiclink_support = true
}

Expected Behavior

Create a VPC with ClassicLink DNS Support enabled

Actual Behavior

Nothing, because this syntax isn't supported yet.
@stack72 stack72 added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 7, 2017
@stack72 stack72 self-assigned this Jul 7, 2017
stack72 added a commit that referenced this issue Jul 7, 2017
@stack72
resource/aws_vpc: Add support for classiclink_dns_support
47bccaa 
Fixes: #1076

```
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpc'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSVpc -timeout 120m
=== RUN   TestAccAWSVpcEndpoint_importBasic
--- PASS: TestAccAWSVpcEndpoint_importBasic (68.54s)
=== RUN   TestAccAWSVpc_importBasic
--- PASS: TestAccAWSVpc_importBasic (53.29s)
=== RUN   TestAccAWSVpcEndpointRouteTableAssociation_basic
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (59.57s)
=== RUN   TestAccAWSVpcEndpoint_basic
--- PASS: TestAccAWSVpcEndpoint_basic (58.48s)
=== RUN   TestAccAWSVpcEndpoint_withRouteTableAndPolicy
--- PASS: TestAccAWSVpcEndpoint_withRouteTableAndPolicy (117.51s)
=== RUN   TestAccAWSVpcEndpoint_WithoutRouteTableOrPolicyConfig
--- PASS: TestAccAWSVpcEndpoint_WithoutRouteTableOrPolicyConfig (53.33s)
=== RUN   TestAccAWSVpcEndpoint_removed
--- PASS: TestAccAWSVpcEndpoint_removed (49.14s)
=== RUN   TestAccAWSVpc_basic
--- PASS: TestAccAWSVpc_basic (45.19s)
=== RUN   TestAccAWSVpc_enableIpv6
--- PASS: TestAccAWSVpc_enableIpv6 (132.93s)
=== RUN   TestAccAWSVpc_dedicatedTenancy
--- PASS: TestAccAWSVpc_dedicatedTenancy (46.52s)
=== RUN   TestAccAWSVpc_tags
--- PASS: TestAccAWSVpc_tags (87.11s)
=== RUN   TestAccAWSVpc_update
--- PASS: TestAccAWSVpc_update (85.61s)
=== RUN   TestAccAWSVpc_DisabledDnsSupport
--- PASS: TestAccAWSVpc_DisabledDnsSupport (43.34s)
=== RUN   TestAccAWSVpc_classiclinkOptionSet
--- PASS: TestAccAWSVpc_classiclinkOptionSet (45.99s)
=== RUN   TestAccAWSVpc_classiclinkDnsSupportOptionSet
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (52.46s)
PASS
ok	github.com/terraform-providers/terraform-provider-aws/aws	1009.082s
```
@stack72 stack72 mentioned this issue Jul 7, 2017
Merged
stack72 added a commit that referenced this issue Jul 7, 2017
@stack72
resource/aws_vpc: Add support for classiclink_dns_support (#1079)
063939e 
Fixes: #1076

```
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpc'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSVpc -timeout 120m
=== RUN   TestAccAWSVpcEndpoint_importBasic
--- PASS: TestAccAWSVpcEndpoint_importBasic (68.54s)
=== RUN   TestAccAWSVpc_importBasic
--- PASS: TestAccAWSVpc_importBasic (53.29s)
=== RUN   TestAccAWSVpcEndpointRouteTableAssociation_basic
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (59.57s)
=== RUN   TestAccAWSVpcEndpoint_basic
--- PASS: TestAccAWSVpcEndpoint_basic (58.48s)
=== RUN   TestAccAWSVpcEndpoint_withRouteTableAndPolicy
--- PASS: TestAccAWSVpcEndpoint_withRouteTableAndPolicy (117.51s)
=== RUN   TestAccAWSVpcEndpoint_WithoutRouteTableOrPolicyConfig
--- PASS: TestAccAWSVpcEndpoint_WithoutRouteTableOrPolicyConfig (53.33s)
=== RUN   TestAccAWSVpcEndpoint_removed
--- PASS: TestAccAWSVpcEndpoint_removed (49.14s)
=== RUN   TestAccAWSVpc_basic
--- PASS: TestAccAWSVpc_basic (45.19s)
=== RUN   TestAccAWSVpc_enableIpv6
--- PASS: TestAccAWSVpc_enableIpv6 (132.93s)
=== RUN   TestAccAWSVpc_dedicatedTenancy
--- PASS: TestAccAWSVpc_dedicatedTenancy (46.52s)
=== RUN   TestAccAWSVpc_tags
--- PASS: TestAccAWSVpc_tags (87.11s)
=== RUN   TestAccAWSVpc_update
--- PASS: TestAccAWSVpc_update (85.61s)
=== RUN   TestAccAWSVpc_DisabledDnsSupport
--- PASS: TestAccAWSVpc_DisabledDnsSupport (43.34s)
=== RUN   TestAccAWSVpc_classiclinkOptionSet
--- PASS: TestAccAWSVpc_classiclinkOptionSet (45.99s)
=== RUN   TestAccAWSVpc_classiclinkDnsSupportOptionSet
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (52.46s)
PASS
ok	github.com/terraform-providers/terraform-provider-aws/aws	1009.082s
```
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost unassigned stack72 Apr 11, 2020
@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resource/aws_vpc: Add support for classiclink_dns_support hashicorp/terraform-provider-aws
2 participants
@stack72 @peimanja