Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ALB weighted target groups #10942

Closed
ewbankkit opened this issue Nov 19, 2019 · 14 comments · Fixed by #12574
Closed

Support ALB weighted target groups #10942

ewbankkit opened this issue Nov 19, 2019 · 14 comments · Fixed by #12574
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Nov 19, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Application Load Balancers now support weighted target groups routing.

New or Affected Resource(s)

Potential Terraform Configuration

resource "aws_lb_listener_rule" "example" {
  action {
    type = "forward"
    ...
  }
}

References

Announcement.
Blog post.

Related:

Requires:

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 19, 2019
@ghost ghost added the service/elbv2 Issues and PRs that pertain to the elbv2 service. label Nov 19, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 19, 2019
@kazeshini178
Copy link

Would this include support for the new conditions available on ALBs?

@tomelliff
Copy link
Contributor

@kazeshini178 what do you mean by that? I think this is referring to https://aws.amazon.com/blogs/aws/new-application-load-balancer-simplifies-deployment-with-weighted-target-groups/ so it would add weighting to the target groups for listeners and listener rules and also the option for target group stickiness.

@ewbankkit
Copy link
Contributor Author

@kazeshini178 The new conditions you are looking for may be addressed by #8126.

@kazeshini178
Copy link

kazeshini178 commented Nov 20, 2019

@ewbankkit Correct, was wondering if that was bundled as part of this request as that thread seems to have gone silent, though I only noticed now that the pull request for it is still active.

@srikanth787
Copy link

@ewbankkit @dpiddockcmp I don't think ask for weighted target groups is implemented through #8126

@aeschright aeschright removed the needs-triage Waiting for first response or review from a maintainer. label Dec 12, 2019
@houstonj1
Copy link

houstonj1 commented Dec 17, 2019

@srikanth787 is right, neither #8126 or #8268 include features requested above, which would be awesome 🙏

@stephen-james-pe
Copy link

Hello, I plan on using this feature soon on a project, is there an estimated time it will be available?

goodspark pushed a commit to goodspark/terraform-provider-aws that referenced this issue Jan 15, 2020
@ADobrodey
Copy link

Enabling target-level stickiness requires that any weighted routing rules associated with this target group have group-level stickiness enabled first. If the target group is not part of a weighted routing rule, there are no prerequisites for enabling target-level stickiness.

Without support of group stickiness in ALB rules CodeDeploy fails with an error:

ERROR: CodeDeployBlueGreen: hudson.AbortException: CodeDeployBlueGreen: Deployment status [Failed] !!!:
code: ELASTIC_LOAD_BALANCING_INVALID
message: The ELB could not be updated due to the following error: You must enable group stickiness on a rule if you enabled target stickiness on one of its target groups.

@rdelcampog
Copy link
Contributor

Enabling target-level stickiness requires that any weighted routing rules associated with this target group have group-level stickiness enabled first. If the target group is not part of a weighted routing rule, there are no prerequisites for enabling target-level stickiness.

Without support of group stickiness in ALB rules CodeDeploy fails with an error:

ERROR: CodeDeployBlueGreen: hudson.AbortException: CodeDeployBlueGreen: Deployment status [Failed] !!!:
code: ELASTIC_LOAD_BALANCING_INVALID
message: The ELB could not be updated due to the following error: You must enable group stickiness on a rule if you enabled target stickiness on one of its target groups.

Check: https://github.com/terraform-providers/terraform-provider-aws/pull/11606/files#r366770507

Must be added to the documentation but I think is expected.

@pbn4
Copy link

pbn4 commented Jan 27, 2020

Enabling target-level stickiness requires that any weighted routing rules associated with this target group have group-level stickiness enabled first. If the target group is not part of a weighted routing rule, there are no prerequisites for enabling target-level stickiness.

Without support of group stickiness in ALB rules CodeDeploy fails with an error:

ERROR: CodeDeployBlueGreen: hudson.AbortException: CodeDeployBlueGreen: Deployment status [Failed] !!!:
code: ELASTIC_LOAD_BALANCING_INVALID
message: The ELB could not be updated due to the following error: You must enable group stickiness on a rule if you enabled target stickiness on one of its target groups.

Any ideas on how to fix this? Moving back to 0.12.19 yields same results.

@lucjross
Copy link

For now I'm using a provisioner for this: https://gist.github.com/lucjross/e1a369a68103d198cb576af866c81b50

@rdelcampog
Copy link
Contributor

Please try this #12574 implementation and vote 👍 in the PR. Hope everything goes OK and is merged soon.

@gdavison gdavison added this to the v2.65.0 milestone Jun 3, 2020
@ghost
Copy link

ghost commented Jun 5, 2020

This has been released in version 2.65.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Projects
None yet