Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: SES configuration set delivery options #11197

Closed
logsnitch opened this issue Dec 8, 2019 · 10 comments · Fixed by #11600
Closed

Feature request: SES configuration set delivery options #11197

logsnitch opened this issue Dec 8, 2019 · 10 comments · Fixed by #11600
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service.
Milestone

Comments

@logsnitch
Copy link

logsnitch commented Dec 8, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Hi, I'd like to request a new resource for creating Amazon SES Configuration Sets "DeliveryOptions": https://docs.aws.amazon.com/ses/latest/APIReference/API_DeliveryOptions.html

New or Affected Resource(s)

aws_ses_configuration_set

Potential Terraform Configuration

resource "aws_ses_configuration_set" "enforce-tls" {
  name = "enforce-tls"

  delivery_options {
    tls_policy = "Require"
  }
}

References

@logsnitch logsnitch added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 8, 2019
@ghost ghost added the service/ses Issues and PRs that pertain to the ses service. label Dec 8, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 8, 2019
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Dec 9, 2019
@marcjay
Copy link
Contributor

marcjay commented Jan 14, 2020

Hi, is this on any roadmap to address or would a PR for this feature be welcomed? This is a feature we'd like to see implemented as well

@marcjay
Copy link
Contributor

marcjay commented Jan 15, 2020

I've raised #11600 based on the syntax above. Happy to change it to support a different syntax if there's a preference.

@marcjay
Copy link
Contributor

marcjay commented Jan 20, 2020

Hi @bflad please could I get your view on the delivery_options syntax here: #11197 (comment) ? If you would like it to be something different I'd be happy to update the PR. Many thanks

@adamdecaf
Copy link

I added this as a new resource which also has sending_pool for #10703. If #11600 is merged I can add sending_pool on the existing aws_ses_configuration_set resource for my change.

My Change: adamdecaf@16045d0

@l13t
Copy link

l13t commented Nov 18, 2020

Hi there. It would be amazing to have possibility to configure TLS policy. We're now configuring SES in our infra and need to have a hack to set this option.

@adamdecaf
Copy link

I never got a reply on this repo for the original PR's, but my fork has been used in production. I'd dust off the PR's if there's a chance they'll get merged.

@marcjay
Copy link
Contributor

marcjay commented Nov 19, 2020

Hi there. It would be amazing to have possibility to configure TLS policy. We're now configuring SES in our infra and need to have a hack to set this option.

@l13t if you add a 👍 to #11600, that I think is the only way to encourage the PR to get merged, I've given up trying to nudge people

@l13t
Copy link

l13t commented Nov 19, 2020

@marcjay already did it and asked colleagues :)

anGie44 pushed a commit that referenced this issue Feb 11, 2021
Update r/aws_ses_configuration_set documentation for delivery_options/tls_policy
References #11197
@anGie44 anGie44 added this to the v3.28.0 milestone Feb 11, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service.
Projects
None yet
6 participants