Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Egress-only internet gateway resource tagging #11563

Closed
ewbankkit opened this issue Jan 11, 2020 · 3 comments · Fixed by #11568
Closed

Egress-only internet gateway resource tagging #11563

ewbankkit opened this issue Jan 11, 2020 · 3 comments · Fixed by #11568
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone
v2.57.0

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Jan 11, 2020 •
edited
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Egress-only internet gateways now support resource tagging.

New or Affected Resource(s)

Potential Terraform Configuration

resource "aws_egress_only_internet_gateway" "example" {
  tags = {
    Usage = "For example use only"
  }
}

References

Requires AWS SDK v1.28.0:

Related:
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 11, 2020
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Jan 11, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 11, 2020
@stefansundin stefansundin mentioned this issue Jan 12, 2020
Merged
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Apr 8, 2020
@bflad bflad added this to the v2.57.0 milestone Apr 8, 2020
bflad added a commit that referenced this issue Apr 8, 2020
@bflad
resource/aws_egress_only_internet_gateway: Finish tags implementation…
a05c40b 
… and fix errors

Reference: #11563

Fixes CI errors for missing `testAccCheckTags` function and removes deprecated `d.SetPartial()` usage.

Output from acceptance testing:

```
--- PASS: TestAccAWSEgressOnlyInternetGateway_basic (30.74s)
--- PASS: TestAccAWSEgressOnlyInternetGateway_Tags (70.04s)
```
@bflad
Copy link
Contributor

bflad commented Apr 8, 2020

Support for this has been merged and will release with version 2.57.0 of the Terraform AWS Provider, later this week. Thanks to @stefansundin for the implementation. 👍

@bflad bflad closed this as completed Apr 8, 2020
@ghost
Copy link

ghost commented Apr 10, 2020

This has been released in version 2.57.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Milestone
v2.57.0
Development

Successfully merging a pull request may close this issue.

r/aws_egress_only_internet_gateway: Add tags argument
2 participants
@bflad @ewbankkit