Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS SecurityHub: the ability to disable specific compliance controls #11624

Closed
marcincuber opened this issue Jan 16, 2020 · 10 comments · Fixed by #14714
Closed

AWS SecurityHub: the ability to disable specific compliance controls #11624

marcincuber opened this issue Jan 16, 2020 · 10 comments · Fixed by #14714
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/securityhub Issues and PRs that pertain to the securityhub service.
Milestone
v3.50.0

Comments

@marcincuber
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

As of Jan 15, 2020, AWS now allows to disable specific compliance controls within AWS SecurityHub. It will be very useful in my case to disable some of them or the ones that are not relevant for my setup.

New or Affected Resource(s)

Potentially new resource

References
@marcincuber marcincuber added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 16, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 16, 2020
@ewbankkit
Copy link
Contributor

Requires AWS SDK v1.28.3:

@steeef
Copy link

steeef commented Jan 24, 2020

Requires AWS SDK v1.28.3:

* #11501

Looks like that was merged. What's next?

@marcincuber
Copy link
Author

Any updates on this?

@DrFaust92 DrFaust92 added the service/securityhub Issues and PRs that pertain to the securityhub service. label May 21, 2020
@Tensho Tensho mentioned this issue Aug 18, 2020
Merged
brettcave added a commit to brettcave/terraform-provider-aws that referenced this issue Aug 21, 2020
@brettcave
hashicorp#11624 security hub standards control resource (partial / un…
63e74af 
…tested)
brettcave added a commit to brettcave/terraform-provider-aws that referenced this issue Aug 21, 2020
@brettcave
hashicorp#11624 building, but not filtering for the control within th…
e08809e 
…e standard.
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 25, 2020
@phundisk
Copy link

phundisk commented Mar 5, 2021

@ewaltman or @brettcave anything I can do to help push this over the line?

@lorengordon lorengordon mentioned this issue Mar 21, 2021
Merged
@brettcave
Copy link

@ewaltman or @brettcave anything I can do to help push this over the line?

@phundisk - I haven't looked at this in a while, I will revisit this.

@jgeurts
Copy link
Contributor

jgeurts commented May 3, 2021

@brettcave (or @ewbankkit) Gentle nudge to see if you've had a chance to take a look at the PR for this issue.

If there's any other way for us to get hashicorp to review stale issues/PRs like this, that would be helpful to know. In the past, thumbs up on the issue was possibly used to triage work, but that seems unreliable and in some cases doesn't seem to make an impact to priority.

@jgeurts
Copy link
Contributor

jgeurts commented May 13, 2021 •
edited
Loading

@ewbankkit @DrFaust92 @bflad Can someone please let us know what is needed to get someone to look at this PR/issue?

@osterman
Copy link

osterman commented Jul 2, 2021

We've added support for this to our cloudposse/awsutils provider by using the awsutils_security_hub_control_disablement resource.

@github-actions github-actions bot added this to the v3.50.0 milestone Jul 13, 2021
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/securityhub Issues and PRs that pertain to the securityhub service.
Projects
None yet
Milestone
v3.50.0
Development

Successfully merging a pull request may close this issue.

New resource: aws_securityhub_standards_control Tensho/terraform-provider-aws
8 participants
@osterman @steeef @brettcave @jgeurts @ewbankkit @phundisk @marcincuber @DrFaust92