Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/ssm_maint_windows_task - add CloudWatch config + plan time validations #11774

Merged
merged 10 commits into from
Feb 12, 2021
Merged

r/ssm_maint_windows_task - add CloudWatch config + plan time validations #11774

merged 10 commits into from
Feb 12, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 27, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13624
Relates #13826
Closes #17554

Release note for CHANGELOG:

resource_aws_ssm_maintance_window_task: add `cloudwatch_config` argument.
resource_aws_ssm_maintance_window_task: add plan time validation to `task_type`, `service_role_arn`, `targets.notification_arn`, `targets.service_role_arn`.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSSMMaintenanceWindowTask_'
--- PASS: TestAccAWSSSMMaintenanceWindowTask_basic (115.08s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource (100.42s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters (139.40s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters (95.09s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters (140.03s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParametersCloudWatch (149.73s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters (68.90s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_emptyNotificationConfig (59.16s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_disappears (57.53s)

@DrFaust92 DrFaust92 requested a review from a team January 27, 2020 17:06
@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ssm Issues and PRs that pertain to the ssm service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 27, 2020
slapula
slapula approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@slapula slapula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuliocalzolari
Copy link

Do you have ETA to merge it?

@giuliocalzolari
Copy link

@slapula do you know when will be merged?

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 21, 2020
@bflad bflad added this to the v2.69.0 milestone Jul 2, 2020
@DrFaust92
Copy link
Collaborator Author

having trouble with CW test, cant find where i messed up at the moment.

@bflad bflad removed this from the v2.69.0 milestone Jul 2, 2020
@DrFaust92
Copy link
Collaborator Author

Rebased

--- PASS: TestAccAWSSSMMaintenanceWindowTask_basic (115.08s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource (100.42s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters (139.40s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters (95.09s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters (140.03s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParametersCloudWatch (149.73s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters (68.90s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_emptyNotificationConfig (59.16s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_disappears (57.53s)

Base automatically changed from master to main January 23, 2021 00:57
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:57
@ghost ghost removed the size/L Managed by automation to categorize the size of a PR. label Feb 11, 2021
@ghost ghost added the size/XL Managed by automation to categorize the size of a PR. label Feb 11, 2021
bflad
bflad reviewed Feb 11, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some touch up before verifying ✨

.changelog/11774.txt Outdated Show resolved Hide resolved
.changelog/11774.txt Outdated Show resolved Hide resolved
aws/resource_aws_ssm_maintenance_window_task.go Outdated Show resolved Hide resolved
aws/resource_aws_ssm_maintenance_window_task.go Outdated Show resolved Hide resolved
aws/resource_aws_ssm_maintenance_window_task.go Outdated Show resolved Hide resolved
aws/resource_aws_ssm_maintenance_window_task.go Outdated Show resolved Hide resolved
@bflad bflad self-assigned this Feb 11, 2021
bflad
bflad approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a bit to get through all the validation updates, but looks good to me. 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSSSMMaintenanceWindowTask_disappears (19.58s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_emptyNotificationConfig (19.85s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters (22.39s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource (34.36s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_basic (35.48s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters (42.68s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParametersCloudWatch (44.70s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters (45.14s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters (46.92s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSSSMMaintenanceWindowTask_disappears (24.63s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_emptyNotificationConfig (24.80s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters (27.60s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters (39.96s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_basic (41.36s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource (41.58s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters (48.45s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters (49.11s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParametersCloudWatch (54.92s)

@bflad bflad linked an issue Feb 12, 2021 that may be closed by this pull request
Allow output logs to CloudWatch for aws_ssm_maintenance_window_task resource #14136
Closed
This was referenced Feb 12, 2021
Closed
Closed
@bflad bflad merged commit 596aa3d into hashicorp:main Feb 12, 2021
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 12, 2021
@bflad bflad mentioned this pull request Feb 12, 2021
Closed
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
@DrFaust92 DrFaust92 deleted the r/ssm_maint_wind branch April 15, 2021 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

@slapula slapula slapula approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.28.0
4 participants
@DrFaust92 @giuliocalzolari @bflad @slapula