-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cloudwatch output config support for run command tasks #14302
Conversation
Just checking in on this PR. It would be really great if we could get this in place, I'm kind of depending on it for SSM patch compliance reporting. Thanks! |
I have fixed the existing conflicts, I am still waiting for a review by a maintainer in order to merge the PR. I hope someone will give me feedback soon Edit: Seems something goes wrong, some checks has failed, I'm going to take a look on it deeper later |
I don't know exactly what is happening with the checks, when I launch terrafmt locally I get many errors not related to my PR. When I have some time I will give another look, if someone wants to contribute to my PR welcome |
was wondering if you ever got any time to take another swing at this. I probably don't know enough go to make a meaningful contribution but this would be an amazing feature to get active! |
This would be really good to have. |
Finally I have had some time and I think I have managed to fix all the issues 🤞 I hope that someone can review it soon :) |
Thanks so much for coming back to this! |
Hi @mycodeself 👋 Thank you for working on this. This functionality is being merged in from the earlier #11774 and will be available in version 3.28.0 of the Terraform AWS Provider releasing later today. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
I have added support for output the logs of run command in a maintenance window tasks to cloudwatch. I've done this based on the PR #12167 that it's inactive for some time. I simply split the tests as proposed in the other PR.
Community Note
Relates OR Closes #14136
Other PR Related #12167
Release note for CHANGELOG:
Output from acceptance testing: