aws_sns_topic_subscription resource produced new value for was present but now absent

[MattMcKeithen]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

2.53.0 (compared to Master - no changes)

Affected Resource(s)

• aws_sns_topic_subscription

Initial Triage

Protocol sqs

It looks like the response to the subscribe request returns "pending confirmation"
and we end up with
'Invalid SNS Subscription, received a "pending confirmation" ARN'

This can be seen by following the logic beginning here:
https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_sns_topic_subscription.go#L223
and here where it returns nil
https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_sns_topic_subscription.go#L109

It appears that if your protocol is http or https it will check for pending confirmation and retry but not for SQS. I don't think it would be too difficult to add a bit of retry logic here for SQS as well?

You can easily reproduce this in the console or cli.
<entry> <key>PendingConfirmation</key> <value>true</value> </entry>

in my case our endpoint is in another account (not sure if that is adding just enough delay?).

Terraform Configuration Files

resource "aws_sns_topic_subscription" "sqs_target" {
  topic_arn  = aws_sns_topic.topic.arn
  protocol   = "sqs"
  endpoint   = "arn:aws:sqs:REGION:OTHER_ACCOUNT:SQS_NAME"
}

Debug Output

Sorry, can't create gist because of network policy :-(

2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4: 2020/04/06 16:07:08 [DEBUG] [aws-sdk-go] DEBUG: Response sns/Subscribe Details:
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4: ---[ RESPONSE ]--------------------------------------
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4: HTTP/1.1 200 OK
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4: Connection: close
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4: Content-Length: 298
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4: Content-Type: text/xml
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4: Date: Mon, 06 Apr 2020 16:07:07 GMT
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4: X-Amzn-Requestid: f1856eaa-ce61-59e5-87b1-39af9b8d044e
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4:
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4:
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4: -----------------------------------------------------
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4: 2020/04/06 16:07:08 [DEBUG] [aws-sdk-go]
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4:
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4: pending confirmation
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4:
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4:
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4: f1856eaa-ce61-59e5-87b1-39af9b8d044e
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4:
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4:
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4: 2020/04/06 16:07:08 [DEBUG] Finished subscribing to topic arn:aws:sns:REGION:ACCOUNT:TOPIC with subscription arn pending confirmation
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4: 2020/04/06 16:07:08 [DEBUG] Created new subscription! pending confirmation
2020-04-06T16:07:08.624Z [DEBUG] plugin.terraform-provider-aws_v2.53.0_x4: 2020/04/06 16:07:08 [WARN] Invalid SNS Subscription, received a "pending confirmation" ARN
2020/04/06 16:07:08 [DEBUG] module.MODULE1.module.MODULE2.module.MODULE3.aws_sns_topic_subscription.SUBSCRIPTION: apply errored, but we're indicating that via the Error pointer rather than returning it: Provider produced inconsistent result after apply: When applying changes to module.MODULE1.module.MODULE2.module.MODULE3.aws_sns_topic_subscription.SUBSCRIPTION, provider "aws" produced an unexpected new value for was present, but now absent.

This is a bug in the provider, which should be reported in the provider's own issue tracker.
2020/04/06 16:07:08 [TRACE] module.MODULE1.module.MODULE2.module.MODULE3: eval: *terraform.EvalMaybeTainted
2020/04/06 16:07:08 [TRACE] EvalMaybeTainted: module.MODULE1.module.MODULE2.module.MODULE3.aws_sns_topic_subscription.SUBSCRIPTION encountered an error during creation, so it is now marked as tainted
2020/04/06 16:07:08 [ERROR] module.MODULE1.module.MODULE2.module.MODULE3: eval: *terraform.EvalApplyPost, err: Provider produced inconsistent result after apply: When applying changes to module.MODULE1.module.MODULE2.module.MODULE3.aws_sns_topic_subscription.SUBSCRIPTION, provider "aws" produced an unexpected new value for was present, but now absent.

This is a bug in the provider, which should be reported in the provider's own issue tracker.
2020/04/06 16:07:08 [ERROR] module.MODULE1.module.MODULE2.module.MODULE3: eval: *terraform.EvalSequence, err: Provider produced inconsistent result after apply: When applying changes to module.MODULE1.module.MODULE2.module.MODULE3.aws_sns_topic_subscription.SUBSCRIPTION, provider "aws" produced an unexpected new value for was present, but now absent.

This is a bug in the provider, which should be reported in the provider's own issue tracker.

Panic Output

Expected Behavior

Create subscription, wait for confirmation to complete, and update state

Actual Behavior

Creates subscription, doesn't wait for confirmation, doesn't update state, throws above error

Steps to Reproduce

1. terraform apply

Important Factoids

SNS subscription endpoint is in another account. Subscription is created but terraform errors and state is not update.

References

• aws_sns_topic_subscription resource produced new value for was present but now absent #11737

[GiedriusQ]

For all of those who are struggling to create subscription to SQS located in different account: firstly you need to add SNS policy (SNS:Subscribe) to allow subscription creation from other account, it can be found here https://docs.aws.amazon.com/sns/latest/dg/sns-send-message-to-sqs-cross-account.html. Then you can create subscription resource using SQS owner's account.

[ghost]

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!