aws_datasync_task: Cloud watch log group ARN regex validation

[stellemd]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform version: 0.12.24

Affected Resource(s)

• aws_datasync_task

Terraform Configuration Files

resource "aws_datasync_task" "this" {
  destination_location_arn = "arn:aws:datasync:us-east-1:123456789123:location/loc-02ca0734e27104g8d"
  source_location_arn      = "arn:aws:datasync:us-east-1:123456789123:location/loc-Xcce5febb7a3a6a45"
  cloudwatch_log_group_arn = aws_cloudwatch_log_group.default.arn
  name                     = "Test Media Sync"

  options {
          atime                  = "BEST_EFFORT"
          bytes_per_second       = -1
          gid                    = "INT_VALUE"
          mtime                  = "PRESERVE"
          posix_permissions      = "PRESERVE"
          preserve_deleted_files = "REMOVE"
          preserve_devices       = "NONE"
          uid                    = "INT_VALUE"
          verify_mode            = "POINT_IN_TIME_CONSISTENT"
        }
}

resource "aws_cloudwatch_log_group" "default" {
  name              = local.cloudwatch_log_group_name
  retention_in_days = 400

  tags =  local.cloudwatch_log_group_tags
}

Debug Output

https://github.com/stellemd/aws_data_sync_task/blob/master/debug.txt

Panic Output

Expected Behavior

The aws data sync task resource will accept the cloud watch log group arn created via an aws_cloudwatch_log_group resource and the cloud watch log group will be attached for task logging.

Actual Behavior

Error: error creating DataSync Task: ValidationException: 1 validation error detected: Value 'arn:aws:logs:us-east-1:123456789123:log-group:test_media_data_sync_non_prod:*' at 'cloudWatchLogGroupArn' failed to satisfy constraint: Member must satisfy regular expression pattern: ^arn:(aws|aws-cn|aws-us-gov|aws-iso|aws-iso-b):logs:[a-z\-0-9]*:[0-9]{12}:log-group:([^:\*]*)$
        status code: 400, request id: 2883fee4-5bf5-4969-8428-bb90fe6fc23b

  on main.tf line 35, in resource "aws_datasync_task" "this":
  35: resource "aws_datasync_task" "this" {

Steps to Reproduce

1. terraform apply

Important Factoids

References

• #0000

[mehfuzh]

Found this workaround for now:

join("", split(":*", aws_cloudwatch_log_group.this.arn))

[bflad]

FYI, this should be resolved in our upcoming major release (version 3.0.0) within the next few weeks. We plan on automatically removing the :* returned in the ARN by the CloudWatch Logs API, so it is like all other Terraform AWS Provider arn attributes. I have marked this issue with that milestone so we know to circle back and close this issue when its resolved as part of that release.

[bflad]

Hi folks 👋 The aws_cloudwatch_log_group change mentioned above has been merged and will go out with version 3.0.0 of the Terraform AWS Provider, likely later today or tomorrow. Configurations in the meantime and with earlier versions of the provider can use the replace() function to remove the suffix. 👍

[ghost]

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[MeMan-MasterOfTheUniverse]

That is not the ARN. You're changing a value that doesn't originate within terraform!?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!