Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/spot_fleet_request - on demand arguments #13127

Merged
merged 21 commits into from
Jun 17, 2021
Merged

r/spot_fleet_request - on demand arguments #13127

merged 21 commits into from
Jun 17, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented May 1, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #7011
Closes #16607

Release note for CHANGELOG:

resource_aws_spot_fleet_request: add `on_demand_allocation_strategy`, `on_demand_max_total_price`, and `on_demand_target_capacity` arguments

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSpotFleetRequest_onDemand'
--- PASS: TestAccAWSSpotFleetRequest_onDemandTargetCapacity (436.81s)
--- PASS: TestAccAWSSpotFleetRequest_onDemandMaxTotalPrice (282.42s)
--- PASS: TestAccAWSSpotFleetRequest_onDemandAllocationStrategy (349.56s)

@DrFaust92 DrFaust92 requested a review from a team May 1, 2020 20:00
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. labels May 1, 2020
@DrFaust92 DrFaust92 changed the title r/spot_fleet_request - on demand arguments [WIP]r/spot_fleet_request - on demand arguments May 1, 2020
@ghost ghost added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels May 2, 2020
@DrFaust92 DrFaust92 force-pushed the r/spot_fleet_request_on_demand branch from 3e6024e to 145c9e9 Compare August 6, 2020 20:26
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Aug 6, 2020
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 6, 2020
@DrFaust92 DrFaust92 changed the title [WIP]r/spot_fleet_request - on demand arguments r/spot_fleet_request - on demand arguments Aug 6, 2020
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. labels Aug 6, 2020
bflad
bflad approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

Output from acceptance testing:

--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (265.32s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (268.23s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (269.41s)
--- PASS: TestAccAWSSpotFleetRequest_onDemandMaxTotalPrice (298.00s)
--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (298.95s)
--- PASS: TestAccAWSSpotFleetRequest_onDemandAllocationStrategy (299.14s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (299.45s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (308.31s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (311.01s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (320.04s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (321.06s)
--- PASS: TestAccAWSSpotFleetRequest_tags (323.47s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (66.41s)
--- PASS: TestAccAWSSpotFleetRequest_basic (398.72s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (400.56s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (152.25s)
--- SKIP: TestAccAWSSpotFleetRequest_WithInstanceStoreAmi (0.00s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (151.07s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (233.65s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (242.84s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (528.27s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (233.75s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (221.23s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (547.23s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (558.12s)
--- PASS: TestAccAWSSpotFleetRequest_onDemandTargetCapacity (576.04s)
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (576.72s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (383.42s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (355.25s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (355.31s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (274.88s)
--- PASS: TestAccAWSSpotFleetRequest_disappears (220.71s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (424.75s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (424.61s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (335.17s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (745.77s)
--- PASS: TestAccAWSSpotFleetRequest_zero_capacity (393.82s)

website/docs/r/spot_fleet_request.html.markdown Show resolved Hide resolved
aws/resource_aws_spot_fleet_request.go Outdated Show resolved Hide resolved
@pschiffe
Copy link

Hello, any updates reg this PR? What is missing?

@DrFaust92 DrFaust92 force-pushed the r/spot_fleet_request_on_demand branch from 0ce695b to 31ab21d Compare October 15, 2020 18:01
@ZillaG
Copy link

ZillaG commented Dec 5, 2020 •
edited
Loading

I gave this a thumbs up. Can we please merge this? The resource IS missing functionality offered by its AWS console counterpart so I can't use it until this feature is merged. Thanks!

@DrFaust92 DrFaust92 force-pushed the r/spot_fleet_request_on_demand branch from 57ce01a to aa1c067 Compare December 5, 2020 19:03
@DrFaust92 DrFaust92 requested a review from a team as a code owner December 5, 2020 19:03
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Dec 5, 2020
DrFaust92 and others added 21 commits June 16, 2021 15:02
@DrFaust92 @ewbankkit
add on demand parmas
d3f5abc
@DrFaust92 @ewbankkit
allow updating on_demand_target_capacity and force new to other on …
55cb6c3 
…demand arguments
@DrFaust92 @ewbankkit
allow zero value on demand target capacity
f5ec049
@DrFaust92 @ewbankkit
add default and validation for on_demand_allocation_strategy
7e0b219
@DrFaust92 @ewbankkit
add docs
c75b129
@DrFaust92 @ewbankkit
add test for on_demand_target_capacity
3471810
@DrFaust92 @ewbankkit
on_demand_fulfilled_capacity can change by other actions, adding co…
e40ee1e 
…mputed

add tests for on demand max price and allocation strategy
@DrFaust92 @ewbankkit
add test for fulfilled capacity
977a5a7
@DrFaust92 @ewbankkit
remove fulfilled capacity
114701f
@DrFaust92 @ewbankkit
remove fulfilled capacity
d538543
@DrFaust92 @ewbankkit
use enum slice
9ccf51c
@DrFaust92 @ewbankkit
rebase
9724cd7
@DrFaust92 @ewbankkit
rebase
348e252
@DrFaust92 @ewbankkit
validations
c99d2d8
@DrFaust92 @ewbankkit
add validations
b10dea8
@DrFaust92 @ewbankkit
changelog
265ce51
@DrFaust92 @ewbankkit
error check
5aee072
@DrFaust92 @ewbankkit
fmt
0add812
@DrFaust92 @ewbankkit
fmt
2976f49
@ewbankkit
r/aws_spot_fleet_request: Don't validate EC2 instance types.
721cbbe
@ewbankkit
r/aws_spot_fleet_request: Instead of 'd.GetOkExists', always set in v…
41715c9 
…alue. Tidy up 'resourceAwsSpotFleetRequestUpdate'.
@ewbankkit ewbankkit force-pushed the r/spot_fleet_request_on_demand branch from 6a06ed4 to 41715c9 Compare June 17, 2021 13:13
@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.
In order to get this merged quickly I pushed a couple of minor changes:

  • Removed the EC2 instance type validations - We don't do this for the aws_instance resource and given the pace at which AWS introduce new instance types I think it could be limiting for practitioners to be restricted to the values that were listed in the version of the AWS Go SDK that was referenced when the provider was built
  • Replaced GetOkExists with plain value assignment (see this comment)

ewbankkit
ewbankkit approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSpotFleetRequest_'                                                                    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSpotFleetRequest_ -timeout 180m
=== RUN   TestAccAWSSpotFleetRequest_basic
=== PAUSE TestAccAWSSpotFleetRequest_basic
=== RUN   TestAccAWSSpotFleetRequest_tags
=== PAUSE TestAccAWSSpotFleetRequest_tags
=== RUN   TestAccAWSSpotFleetRequest_associatePublicIpAddress
=== PAUSE TestAccAWSSpotFleetRequest_associatePublicIpAddress
=== RUN   TestAccAWSSpotFleetRequest_launchTemplate
=== PAUSE TestAccAWSSpotFleetRequest_launchTemplate
=== RUN   TestAccAWSSpotFleetRequest_launchTemplate_multiple
=== PAUSE TestAccAWSSpotFleetRequest_launchTemplate_multiple
=== RUN   TestAccAWSSpotFleetRequest_launchTemplateWithOverrides
=== PAUSE TestAccAWSSpotFleetRequest_launchTemplateWithOverrides
=== RUN   TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec
=== PAUSE TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec
=== RUN   TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate
=== PAUSE TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate
=== RUN   TestAccAWSSpotFleetRequest_onDemandTargetCapacity
=== PAUSE TestAccAWSSpotFleetRequest_onDemandTargetCapacity
=== RUN   TestAccAWSSpotFleetRequest_onDemandMaxTotalPrice
=== PAUSE TestAccAWSSpotFleetRequest_onDemandMaxTotalPrice
=== RUN   TestAccAWSSpotFleetRequest_onDemandAllocationStrategy
=== PAUSE TestAccAWSSpotFleetRequest_onDemandAllocationStrategy
=== RUN   TestAccAWSSpotFleetRequest_instanceInterruptionBehavior
=== PAUSE TestAccAWSSpotFleetRequest_instanceInterruptionBehavior
=== RUN   TestAccAWSSpotFleetRequest_fleetType
=== PAUSE TestAccAWSSpotFleetRequest_fleetType
=== RUN   TestAccAWSSpotFleetRequest_iamInstanceProfileArn
=== PAUSE TestAccAWSSpotFleetRequest_iamInstanceProfileArn
=== RUN   TestAccAWSSpotFleetRequest_changePriceForcesNewRequest
=== PAUSE TestAccAWSSpotFleetRequest_changePriceForcesNewRequest
=== RUN   TestAccAWSSpotFleetRequest_updateTargetCapacity
=== PAUSE TestAccAWSSpotFleetRequest_updateTargetCapacity
=== RUN   TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy
=== PAUSE TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy
=== RUN   TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion
=== PAUSE TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion
=== RUN   TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList
=== PAUSE TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList
=== RUN   TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList
=== PAUSE TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList
=== RUN   TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz
=== PAUSE TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz
=== RUN   TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet
=== PAUSE TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet
=== RUN   TestAccAWSSpotFleetRequest_overriddingSpotPrice
=== PAUSE TestAccAWSSpotFleetRequest_overriddingSpotPrice
=== RUN   TestAccAWSSpotFleetRequest_withoutSpotPrice
=== PAUSE TestAccAWSSpotFleetRequest_withoutSpotPrice
=== RUN   TestAccAWSSpotFleetRequest_diversifiedAllocation
=== PAUSE TestAccAWSSpotFleetRequest_diversifiedAllocation
=== RUN   TestAccAWSSpotFleetRequest_multipleInstancePools
=== PAUSE TestAccAWSSpotFleetRequest_multipleInstancePools
=== RUN   TestAccAWSSpotFleetRequest_withWeightedCapacity
=== PAUSE TestAccAWSSpotFleetRequest_withWeightedCapacity
=== RUN   TestAccAWSSpotFleetRequest_withEBSDisk
=== PAUSE TestAccAWSSpotFleetRequest_withEBSDisk
=== RUN   TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId
=== PAUSE TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId
=== RUN   TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId
=== PAUSE TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId
=== RUN   TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3
=== PAUSE TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3
=== RUN   TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3
=== PAUSE TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3
=== RUN   TestAccAWSSpotFleetRequest_withTags
=== PAUSE TestAccAWSSpotFleetRequest_withTags
=== RUN   TestAccAWSSpotFleetRequest_placementTenancyAndGroup
=== PAUSE TestAccAWSSpotFleetRequest_placementTenancyAndGroup
=== RUN   TestAccAWSSpotFleetRequest_WithELBs
=== PAUSE TestAccAWSSpotFleetRequest_WithELBs
=== RUN   TestAccAWSSpotFleetRequest_WithTargetGroups
=== PAUSE TestAccAWSSpotFleetRequest_WithTargetGroups
=== RUN   TestAccAWSSpotFleetRequest_zero_capacity
=== PAUSE TestAccAWSSpotFleetRequest_zero_capacity
=== RUN   TestAccAWSSpotFleetRequest_CapacityRebalance
=== PAUSE TestAccAWSSpotFleetRequest_CapacityRebalance
=== RUN   TestAccAWSSpotFleetRequest_WithInstanceStoreAmi
    provider_test.go:57: Test fails due to test harness constraints
--- SKIP: TestAccAWSSpotFleetRequest_WithInstanceStoreAmi (0.00s)
=== RUN   TestAccAWSSpotFleetRequest_disappears
=== PAUSE TestAccAWSSpotFleetRequest_disappears
=== CONT  TestAccAWSSpotFleetRequest_basic
=== CONT  TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz
=== CONT  TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId
=== CONT  TestAccAWSSpotFleetRequest_onDemandAllocationStrategy
=== CONT  TestAccAWSSpotFleetRequest_disappears
=== CONT  TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId
=== CONT  TestAccAWSSpotFleetRequest_withEBSDisk
=== CONT  TestAccAWSSpotFleetRequest_withWeightedCapacity
=== CONT  TestAccAWSSpotFleetRequest_placementTenancyAndGroup
=== CONT  TestAccAWSSpotFleetRequest_instanceInterruptionBehavior
=== CONT  TestAccAWSSpotFleetRequest_multipleInstancePools
=== CONT  TestAccAWSSpotFleetRequest_diversifiedAllocation
=== CONT  TestAccAWSSpotFleetRequest_withoutSpotPrice
=== CONT  TestAccAWSSpotFleetRequest_overriddingSpotPrice
=== CONT  TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet
=== CONT  TestAccAWSSpotFleetRequest_updateTargetCapacity
=== CONT  TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList
=== CONT  TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3
=== CONT  TestAccAWSSpotFleetRequest_WithELBs
=== CONT  TestAccAWSSpotFleetRequest_WithTargetGroups
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (78.20s)
=== CONT  TestAccAWSSpotFleetRequest_CapacityRebalance
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (126.34s)
=== CONT  TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList
--- PASS: TestAccAWSSpotFleetRequest_onDemandAllocationStrategy (146.20s)
=== CONT  TestAccAWSSpotFleetRequest_launchTemplateWithOverrides
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3 (146.66s)
=== CONT  TestAccAWSSpotFleetRequest_onDemandMaxTotalPrice
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (161.49s)
=== CONT  TestAccAWSSpotFleetRequest_onDemandTargetCapacity
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (161.53s)
=== CONT  TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate
--- PASS: TestAccAWSSpotFleetRequest_disappears (164.98s)
=== CONT  TestAccAWSSpotFleetRequest_zero_capacity
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (165.87s)
=== CONT  TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (166.14s)
=== CONT  TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (167.17s)
=== CONT  TestAccAWSSpotFleetRequest_launchTemplate
--- PASS: TestAccAWSSpotFleetRequest_basic (171.54s)
=== CONT  TestAccAWSSpotFleetRequest_withTags
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (172.07s)
=== CONT  TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (174.74s)
=== CONT  TestAccAWSSpotFleetRequest_launchTemplate_multiple
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (177.65s)
=== CONT  TestAccAWSSpotFleetRequest_iamInstanceProfileArn
--- PASS: TestAccAWSSpotFleetRequest_CapacityRebalance (119.29s)
=== CONT  TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (202.42s)
=== CONT  TestAccAWSSpotFleetRequest_associatePublicIpAddress
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (206.10s)
=== CONT  TestAccAWSSpotFleetRequest_changePriceForcesNewRequest
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (206.69s)
=== CONT  TestAccAWSSpotFleetRequest_tags
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (223.41s)
=== CONT  TestAccAWSSpotFleetRequest_fleetType
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (124.24s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (130.30s)
--- PASS: TestAccAWSSpotFleetRequest_onDemandMaxTotalPrice (140.75s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (117.47s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (133.56s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (122.39s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (133.82s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (128.04s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (303.04s)
--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (116.43s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3 (123.11s)
--- PASS: TestAccAWSSpotFleetRequest_zero_capacity (181.26s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (124.50s)
--- PASS: TestAccAWSSpotFleetRequest_tags (146.05s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (379.77s)
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (225.46s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (236.91s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (236.66s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (218.91s)
--- PASS: TestAccAWSSpotFleetRequest_onDemandTargetCapacity (287.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	452.768s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSpotFleetRequest_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSpotFleetRequest_ -timeout 180m
=== RUN   TestAccAWSSpotFleetRequest_basic
=== PAUSE TestAccAWSSpotFleetRequest_basic
=== RUN   TestAccAWSSpotFleetRequest_tags
=== PAUSE TestAccAWSSpotFleetRequest_tags
=== RUN   TestAccAWSSpotFleetRequest_associatePublicIpAddress
=== PAUSE TestAccAWSSpotFleetRequest_associatePublicIpAddress
=== RUN   TestAccAWSSpotFleetRequest_launchTemplate
=== PAUSE TestAccAWSSpotFleetRequest_launchTemplate
=== RUN   TestAccAWSSpotFleetRequest_launchTemplate_multiple
=== PAUSE TestAccAWSSpotFleetRequest_launchTemplate_multiple
=== RUN   TestAccAWSSpotFleetRequest_launchTemplateWithOverrides
=== PAUSE TestAccAWSSpotFleetRequest_launchTemplateWithOverrides
=== RUN   TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec
=== PAUSE TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec
=== RUN   TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate
=== PAUSE TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate
=== RUN   TestAccAWSSpotFleetRequest_onDemandTargetCapacity
=== PAUSE TestAccAWSSpotFleetRequest_onDemandTargetCapacity
=== RUN   TestAccAWSSpotFleetRequest_onDemandMaxTotalPrice
=== PAUSE TestAccAWSSpotFleetRequest_onDemandMaxTotalPrice
=== RUN   TestAccAWSSpotFleetRequest_onDemandAllocationStrategy
=== PAUSE TestAccAWSSpotFleetRequest_onDemandAllocationStrategy
=== RUN   TestAccAWSSpotFleetRequest_instanceInterruptionBehavior
=== PAUSE TestAccAWSSpotFleetRequest_instanceInterruptionBehavior
=== RUN   TestAccAWSSpotFleetRequest_fleetType
=== PAUSE TestAccAWSSpotFleetRequest_fleetType
=== RUN   TestAccAWSSpotFleetRequest_iamInstanceProfileArn
=== PAUSE TestAccAWSSpotFleetRequest_iamInstanceProfileArn
=== RUN   TestAccAWSSpotFleetRequest_changePriceForcesNewRequest
=== PAUSE TestAccAWSSpotFleetRequest_changePriceForcesNewRequest
=== RUN   TestAccAWSSpotFleetRequest_updateTargetCapacity
=== PAUSE TestAccAWSSpotFleetRequest_updateTargetCapacity
=== RUN   TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy
=== PAUSE TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy
=== RUN   TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion
=== PAUSE TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion
=== RUN   TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList
=== PAUSE TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList
=== RUN   TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList
=== PAUSE TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList
=== RUN   TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz
=== PAUSE TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz
=== RUN   TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet
=== PAUSE TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet
=== RUN   TestAccAWSSpotFleetRequest_overriddingSpotPrice
=== PAUSE TestAccAWSSpotFleetRequest_overriddingSpotPrice
=== RUN   TestAccAWSSpotFleetRequest_withoutSpotPrice
=== PAUSE TestAccAWSSpotFleetRequest_withoutSpotPrice
=== RUN   TestAccAWSSpotFleetRequest_diversifiedAllocation
=== PAUSE TestAccAWSSpotFleetRequest_diversifiedAllocation
=== RUN   TestAccAWSSpotFleetRequest_multipleInstancePools
=== PAUSE TestAccAWSSpotFleetRequest_multipleInstancePools
=== RUN   TestAccAWSSpotFleetRequest_withWeightedCapacity
=== PAUSE TestAccAWSSpotFleetRequest_withWeightedCapacity
=== RUN   TestAccAWSSpotFleetRequest_withEBSDisk
=== PAUSE TestAccAWSSpotFleetRequest_withEBSDisk
=== RUN   TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId
=== PAUSE TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId
=== RUN   TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId
=== PAUSE TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId
=== RUN   TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3
=== PAUSE TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3
=== RUN   TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3
=== PAUSE TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3
=== RUN   TestAccAWSSpotFleetRequest_withTags
=== PAUSE TestAccAWSSpotFleetRequest_withTags
=== RUN   TestAccAWSSpotFleetRequest_placementTenancyAndGroup
=== PAUSE TestAccAWSSpotFleetRequest_placementTenancyAndGroup
=== RUN   TestAccAWSSpotFleetRequest_WithELBs
=== PAUSE TestAccAWSSpotFleetRequest_WithELBs
=== RUN   TestAccAWSSpotFleetRequest_WithTargetGroups
=== PAUSE TestAccAWSSpotFleetRequest_WithTargetGroups
=== RUN   TestAccAWSSpotFleetRequest_zero_capacity
=== PAUSE TestAccAWSSpotFleetRequest_zero_capacity
=== RUN   TestAccAWSSpotFleetRequest_CapacityRebalance
=== PAUSE TestAccAWSSpotFleetRequest_CapacityRebalance
=== RUN   TestAccAWSSpotFleetRequest_WithInstanceStoreAmi
    provider_test.go:57: Test fails due to test harness constraints
--- SKIP: TestAccAWSSpotFleetRequest_WithInstanceStoreAmi (0.00s)
=== RUN   TestAccAWSSpotFleetRequest_disappears
=== PAUSE TestAccAWSSpotFleetRequest_disappears
=== CONT  TestAccAWSSpotFleetRequest_basic
=== CONT  TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz
=== CONT  TestAccAWSSpotFleetRequest_onDemandAllocationStrategy
=== CONT  TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList
=== CONT  TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList
=== CONT  TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion
=== CONT  TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy
=== CONT  TestAccAWSSpotFleetRequest_updateTargetCapacity
=== CONT  TestAccAWSSpotFleetRequest_changePriceForcesNewRequest
=== CONT  TestAccAWSSpotFleetRequest_iamInstanceProfileArn
=== CONT  TestAccAWSSpotFleetRequest_fleetType
=== CONT  TestAccAWSSpotFleetRequest_instanceInterruptionBehavior
=== CONT  TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3
=== CONT  TestAccAWSSpotFleetRequest_disappears
=== CONT  TestAccAWSSpotFleetRequest_CapacityRebalance
=== CONT  TestAccAWSSpotFleetRequest_zero_capacity
=== CONT  TestAccAWSSpotFleetRequest_WithTargetGroups
=== CONT  TestAccAWSSpotFleetRequest_WithELBs
=== CONT  TestAccAWSSpotFleetRequest_placementTenancyAndGroup
=== CONT  TestAccAWSSpotFleetRequest_launchTemplateWithOverrides
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (80.07s)
=== CONT  TestAccAWSSpotFleetRequest_withTags
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (139.77s)
=== CONT  TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3
--- PASS: TestAccAWSSpotFleetRequest_CapacityRebalance (141.20s)
=== CONT  TestAccAWSSpotFleetRequest_onDemandTargetCapacity
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (144.31s)
=== CONT  TestAccAWSSpotFleetRequest_onDemandMaxTotalPrice
--- PASS: TestAccAWSSpotFleetRequest_basic (150.50s)
=== CONT  TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (155.98s)
=== CONT  TestAccAWSSpotFleetRequest_launchTemplate
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (155.98s)
=== CONT  TestAccAWSSpotFleetRequest_launchTemplate_multiple
--- PASS: TestAccAWSSpotFleetRequest_onDemandAllocationStrategy (156.95s)
=== CONT  TestAccAWSSpotFleetRequest_multipleInstancePools
--- PASS: TestAccAWSSpotFleetRequest_disappears (158.90s)
=== CONT  TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (162.22s)
=== CONT  TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (166.09s)
=== CONT  TestAccAWSSpotFleetRequest_withEBSDisk
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3 (167.11s)
=== CONT  TestAccAWSSpotFleetRequest_withWeightedCapacity
--- PASS: TestAccAWSSpotFleetRequest_fleetType (175.63s)
=== CONT  TestAccAWSSpotFleetRequest_associatePublicIpAddress
--- PASS: TestAccAWSSpotFleetRequest_withTags (121.84s)
=== CONT  TestAccAWSSpotFleetRequest_tags
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (203.77s)
=== CONT  TestAccAWSSpotFleetRequest_withoutSpotPrice
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (206.74s)
=== CONT  TestAccAWSSpotFleetRequest_diversifiedAllocation
--- PASS: TestAccAWSSpotFleetRequest_zero_capacity (260.02s)
=== CONT  TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec
=== CONT  TestAccAWSSpotFleetRequest_overriddingSpotPrice
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (262.31s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (265.76s)
=== CONT  TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3 (130.68s)
--- PASS: TestAccAWSSpotFleetRequest_onDemandMaxTotalPrice (127.50s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (126.86s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (127.45s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (134.77s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (136.16s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (126.40s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (141.44s)
--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (123.51s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (116.33s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (321.33s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (128.09s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (180.61s)
--- PASS: TestAccAWSSpotFleetRequest_tags (150.96s)
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (221.51s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (388.30s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (132.18s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (151.23s)
--- PASS: TestAccAWSSpotFleetRequest_onDemandTargetCapacity (293.73s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (227.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	491.847s

@ewbankkit ewbankkit merged commit 111b55e into hashicorp:main Jun 17, 2021
@github-actions github-actions bot added this to the v3.46.0 milestone Jun 17, 2021
@github-actions
Copy link

This functionality has been released in v3.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the r/spot_fleet_request_on_demand branch June 18, 2021 05:34
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.46.0
5 participants
@DrFaust92 @pschiffe @ZillaG @ewbankkit @bflad