Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: r/aws_kinesis_analytics_application: Use waiters package #13280

Closed
ewbankkit opened this issue May 12, 2020 · 2 comments · Fixed by #16005
Closed

Tech debt: r/aws_kinesis_analytics_application: Use waiters package #13280

ewbankkit opened this issue May 12, 2020 · 2 comments · Fixed by #16005
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kinesis Issues and PRs that pertain to the kinesis service. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service.
Milestone
v3.14.0

Comments

@ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Relates #13153.
Relates #12840.

An aws/internal/service/kinesisanalytics/waiter package was added in #13153, but used just in the test sweeper. Refactor the resource's code to use this package.

New or Affected Resource(s)

  • aws_kinesis_analytics_application
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label May 12, 2020
@ghost ghost added service/kinesis Issues and PRs that pertain to the kinesis service. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. labels May 12, 2020
@ewbankkit ewbankkit mentioned this issue Nov 3, 2020
Merged
ewbankkit added a commit to ewbankkit/terraform-provider-aws that referenced this issue Nov 3, 2020
@ewbankkit
r/aws_kinesis_analytics_application: Use internal 'waiters' package o…
959f8a5 
…n deletion (hashicorp#13280).

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSKinesisAnalyticsApplication_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSKinesisAnalyticsApplication_ -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_basic
=== PAUSE TestAccAWSKinesisAnalyticsApplication_basic
=== RUN   TestAccAWSKinesisAnalyticsApplication_update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_update
=== RUN   TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== PAUSE TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== RUN   TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== PAUSE TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsMultiple
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsMultiple
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
=== RUN   TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== PAUSE TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== RUN   TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== PAUSE TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== RUN   TestAccAWSKinesisAnalyticsApplication_tags
=== PAUSE TestAccAWSKinesisAnalyticsApplication_tags
=== CONT  TestAccAWSKinesisAnalyticsApplication_basic
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsMultiple
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (19.40s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_tags
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsMultiple (66.12s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
--- PASS: TestAccAWSKinesisAnalyticsApplication_tags (60.78s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_referenceDataSource
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (32.24s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (64.81s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (39.02s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (60.92s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsAdd
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (80.41s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (125.10s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (65.49s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (64.48s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsAdd
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (78.44s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (126.32s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (52.70s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (38.18s)
=== CONT  TestAccAWSKinesisAnalyticsApplication_update
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (32.43s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose (85.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	549.570s
@breathingdust breathingdust added this to the v3.14.0 milestone Nov 5, 2020
@ghost
Copy link

ghost commented Nov 6, 2020

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kinesis Issues and PRs that pertain to the kinesis service. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service.
Projects
None yet
Milestone
v3.14.0
Development

Successfully merging a pull request may close this issue.

r/aws_kinesis_analytics_application: Correct resource update ewbankkit/terraform-provider-aws
2 participants
@breathingdust @ewbankkit