Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parameter "version-name" to resource "aws_ssm_document" #14107

Closed
eballetbaz opened this issue Jul 9, 2020 · 3 comments · Fixed by #14128
Closed

Add support for parameter "version-name" to resource "aws_ssm_document" #14107

eballetbaz opened this issue Jul 9, 2020 · 3 comments · Fixed by #14128
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service.
Milestone

Comments

@eballetbaz
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The AWS CLI API allows to specify the "version-name" when creating an "aws_ssm_document"
https://docs.aws.amazon.com/cli/latest/reference/ssm/create-document.html

This version is very usefull to work with progressive deployment, and even quite mandatory
So please add support for parameter "version-name" to resource "aws_ssm_document"

New or Affected Resource(s)

https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_ssm_document.go

Potential Terraform Configuration

resource "aws_ssm_document" "agent_install" {
  name            = "Agent-Install"
  document_type   = "Package"
  document_format = "JSON"
  version-name   = "release-1.0.0"

  content = <<DOC
{
  "schemaVersion": "2.0",
  "description" : "Agent installation",
  "version": "release-1.0.0",
  "packages": {
    "windows": {
      "_any": {
        "_any": {
          "file": "${local.agent_build_file}"
        }
      }
    }
  },
  "files": {
    "${local.agent_build_file}": {
      "checksums": {
        "sha256": "${filesha256("${local.build_packages_dir}/${local.agent_build_file}")}"
      }
    }
  }
}
DOC
}

  attachments_source {
    key    = "SourceUrl"
    values = [ "s3://xxx" ]
  }
}

References

https://docs.aws.amazon.com/cli/latest/reference/ssm/create-document.html
https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_ssm_document.go

@eballetbaz eballetbaz added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 9, 2020
@ghost ghost added the service/ssm Issues and PRs that pertain to the ssm service. label Jul 9, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 9, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Jul 10, 2020
@bflad bflad self-assigned this Feb 12, 2021
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 12, 2021
@bflad
Copy link
Contributor

bflad commented Feb 12, 2021

Support for this functionality has been merged and will release with version 3.28.0 of the Terraform AWS Provider, later today. Thank you to @drexler for the implementation. 👍

@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants