Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_ssm_document - support VersionName parameter #14128

Merged
merged 4 commits into from
Feb 12, 2021
Merged

r/aws_ssm_document - support VersionName parameter #14128

merged 4 commits into from
Feb 12, 2021

Conversation

drexler
Copy link
Contributor

@drexler drexler commented Jul 9, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14107

Release note for CHANGELOG:

Support VersionName parameter for aws_ssm_document resource

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMDocument'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSSMDocument -timeout 120m
=== RUN   TestAccAWSSSMDocument_basic
=== PAUSE TestAccAWSSSMDocument_basic
=== RUN   TestAccAWSSSMDocument_target_type
=== PAUSE TestAccAWSSSMDocument_target_type
=== RUN   TestAccAWSSSMDocument_version_name
=== PAUSE TestAccAWSSSMDocument_version_name
=== RUN   TestAccAWSSSMDocument_update
=== PAUSE TestAccAWSSSMDocument_update
=== RUN   TestAccAWSSSMDocument_permission_public
=== PAUSE TestAccAWSSSMDocument_permission_public
=== RUN   TestAccAWSSSMDocument_permission_private
=== PAUSE TestAccAWSSSMDocument_permission_private
=== RUN   TestAccAWSSSMDocument_permission_batching
=== PAUSE TestAccAWSSSMDocument_permission_batching
=== RUN   TestAccAWSSSMDocument_permission_change
=== PAUSE TestAccAWSSSMDocument_permission_change
=== RUN   TestAccAWSSSMDocument_params
=== PAUSE TestAccAWSSSMDocument_params
=== RUN   TestAccAWSSSMDocument_automation
=== PAUSE TestAccAWSSSMDocument_automation
=== RUN   TestAccAWSSSMDocument_package
=== PAUSE TestAccAWSSSMDocument_package
=== RUN   TestAccAWSSSMDocument_SchemaVersion_1
=== PAUSE TestAccAWSSSMDocument_SchemaVersion_1
=== RUN   TestAccAWSSSMDocument_session
=== PAUSE TestAccAWSSSMDocument_session
=== RUN   TestAccAWSSSMDocument_DocumentFormat_YAML
=== PAUSE TestAccAWSSSMDocument_DocumentFormat_YAML
=== RUN   TestAccAWSSSMDocument_Tags
=== PAUSE TestAccAWSSSMDocument_Tags
=== CONT  TestAccAWSSSMDocument_basic
=== CONT  TestAccAWSSSMDocument_params
=== CONT  TestAccAWSSSMDocument_Tags
=== CONT  TestAccAWSSSMDocument_DocumentFormat_YAML
=== CONT  TestAccAWSSSMDocument_session
=== CONT  TestAccAWSSSMDocument_SchemaVersion_1
=== CONT  TestAccAWSSSMDocument_package
=== CONT  TestAccAWSSSMDocument_automation
=== CONT  TestAccAWSSSMDocument_permission_public
=== CONT  TestAccAWSSSMDocument_permission_change
=== CONT  TestAccAWSSSMDocument_permission_batching
=== CONT  TestAccAWSSSMDocument_permission_private
=== CONT  TestAccAWSSSMDocument_version_name
=== CONT  TestAccAWSSSMDocument_target_type
=== CONT  TestAccAWSSSMDocument_update
--- PASS: TestAccAWSSSMDocument_session (29.82s)
--- PASS: TestAccAWSSSMDocument_permission_public (37.99s)
--- PASS: TestAccAWSSSMDocument_permission_private (44.34s)
--- PASS: TestAccAWSSSMDocument_permission_batching (47.99s)
--- PASS: TestAccAWSSSMDocument_params (51.48s)
--- PASS: TestAccAWSSSMDocument_automation (51.62s)
--- PASS: TestAccAWSSSMDocument_target_type (55.04s)
--- PASS: TestAccAWSSSMDocument_SchemaVersion_1 (61.63s)
--- PASS: TestAccAWSSSMDocument_Tags (63.34s)
--- PASS: TestAccAWSSSMDocument_package (64.46s)
--- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (64.82s)
--- PASS: TestAccAWSSSMDocument_update (74.92s)
--- PASS: TestAccAWSSSMDocument_permission_change (76.45s)
--- PASS: TestAccAWSSSMDocument_version_name (86.55s)
--- PASS: TestAccAWSSSMDocument_basic (118.95s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       119.068s

...

@drexler drexler requested a review from a team July 9, 2020 23:44
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 9, 2020
Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 12, 2021
@bflad bflad self-assigned this Feb 12, 2021
bflad
bflad reviewed Feb 12, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this as well, @drexler. Overall looks pretty good, just some minor things to retrigger CI and will verify the UpdateDocument API behavior. 👍

aws/resource_aws_ssm_document_test.go Outdated Show resolved Hide resolved
website/docs/r/ssm_document.html.markdown Outdated Show resolved Hide resolved
aws/resource_aws_ssm_document.go
Type: schema.TypeString,
Optional: true,
Computed: true,
ForceNew: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oddly enough, the UpdateDocument API operation also accepts VersionName, so going to verify its behavior on merge.

bflad
bflad approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, @drexler 🚀 I was able to verify that the UpdateDocument VersionName support works as long as the content is updated as well. 👍

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSSSMDocument_params (30.50s)
--- PASS: TestAccAWSSSMDocument_basic (32.24s)
--- PASS: TestAccAWSSSMDocument_session (32.29s)
--- PASS: TestAccAWSSSMDocument_permission_private (32.51s)
--- PASS: TestAccAWSSSMDocument_permission_batching (32.78s)
--- PASS: TestAccAWSSSMDocument_permission_public (32.80s)
--- PASS: TestAccAWSSSMDocument_automation (37.50s)
--- PASS: TestAccAWSSSMDocument_VersionName (46.97s)
--- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (46.99s)
--- PASS: TestAccAWSSSMDocument_target_type (48.06s)
--- PASS: TestAccAWSSSMDocument_update (48.17s)
--- PASS: TestAccAWSSSMDocument_SchemaVersion_1 (48.20s)
--- PASS: TestAccAWSSSMDocument_Tags (57.02s)
--- PASS: TestAccAWSSSMDocument_permission_change (57.33s)
--- PASS: TestAccAWSSSMDocument_package (73.74s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSSSMDocument_basic (34.86s)
--- PASS: TestAccAWSSSMDocument_session (39.41s)
--- PASS: TestAccAWSSSMDocument_params (39.84s)
--- PASS: TestAccAWSSSMDocument_permission_private (40.26s)
--- PASS: TestAccAWSSSMDocument_permission_public (40.37s)
--- PASS: TestAccAWSSSMDocument_permission_batching (40.94s)
--- PASS: TestAccAWSSSMDocument_automation (52.65s)
--- PASS: TestAccAWSSSMDocument_target_type (54.33s)
--- PASS: TestAccAWSSSMDocument_update (55.65s)
--- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (55.72s)
--- PASS: TestAccAWSSSMDocument_VersionName (55.79s)
--- PASS: TestAccAWSSSMDocument_SchemaVersion_1 (55.96s)
--- PASS: TestAccAWSSSMDocument_Tags (66.39s)
--- PASS: TestAccAWSSSMDocument_permission_change (68.28s)
--- PASS: TestAccAWSSSMDocument_package (80.15s)

bflad added a commit that referenced this pull request Feb 12, 2021
@bflad
resource/aws_ssm_document: Support in-place version_name updates, add…
bbae8ed 
… CHANGELOG entry for #14128

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSSSMDocument_params (30.50s)
--- PASS: TestAccAWSSSMDocument_basic (32.24s)
--- PASS: TestAccAWSSSMDocument_session (32.29s)
--- PASS: TestAccAWSSSMDocument_permission_private (32.51s)
--- PASS: TestAccAWSSSMDocument_permission_batching (32.78s)
--- PASS: TestAccAWSSSMDocument_permission_public (32.80s)
--- PASS: TestAccAWSSSMDocument_automation (37.50s)
--- PASS: TestAccAWSSSMDocument_VersionName (46.97s)
--- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (46.99s)
--- PASS: TestAccAWSSSMDocument_target_type (48.06s)
--- PASS: TestAccAWSSSMDocument_update (48.17s)
--- PASS: TestAccAWSSSMDocument_SchemaVersion_1 (48.20s)
--- PASS: TestAccAWSSSMDocument_Tags (57.02s)
--- PASS: TestAccAWSSSMDocument_permission_change (57.33s)
--- PASS: TestAccAWSSSMDocument_package (73.74s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSSSMDocument_basic (34.86s)
--- PASS: TestAccAWSSSMDocument_session (39.41s)
--- PASS: TestAccAWSSSMDocument_params (39.84s)
--- PASS: TestAccAWSSSMDocument_permission_private (40.26s)
--- PASS: TestAccAWSSSMDocument_permission_public (40.37s)
--- PASS: TestAccAWSSSMDocument_permission_batching (40.94s)
--- PASS: TestAccAWSSSMDocument_automation (52.65s)
--- PASS: TestAccAWSSSMDocument_target_type (54.33s)
--- PASS: TestAccAWSSSMDocument_update (55.65s)
--- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (55.72s)
--- PASS: TestAccAWSSSMDocument_VersionName (55.79s)
--- PASS: TestAccAWSSSMDocument_SchemaVersion_1 (55.96s)
--- PASS: TestAccAWSSSMDocument_Tags (66.39s)
--- PASS: TestAccAWSSSMDocument_permission_change (68.28s)
--- PASS: TestAccAWSSSMDocument_package (80.15s)
```
@bflad bflad merged commit 8ce6d55 into hashicorp:main Feb 12, 2021
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 12, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.28.0
Development

Successfully merging this pull request may close these issues.

Add support for parameter "version-name" to resource "aws_ssm_document"
2 participants
@drexler @bflad