Add mount_name to aws_fsx_lustre_file_system #14313

mtpdt · 2020-07-23T03:08:07Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource/aws_fsx_lustre_file_system: Add `mount_name`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSFsxLustreFileSystem_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_basic -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_basic
--- PASS: TestAccAWSFsxLustreFileSystem_basic (500.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	500.359s

mtpdt · 2020-07-23T03:10:44Z

The mount_name is required for automation with the PERSISTENT1 FSX lustre deployment type (which I am adding support for in #13639 . For SCRATCH1, it is always fsx, but for PERSISTENT1, it is autogenerated by AWS, so retrieving it dynamically via terraform is important.

DrFaust92 · 2020-07-24T19:53:18Z

@mtpdt, looks good, more tests will need to be added after #13639 is merged

DrFaust92 · 2020-07-29T06:53:51Z

@mtpdt can you rebase this branch and add the mentioned tests?

mtpdt · 2020-07-31T13:58:54Z

Okay, will do

mtpdt · 2020-08-01T17:40:54Z

aws/resource_aws_fsx_lustre_file_system_test.go

@@ -403,6 +404,8 @@ func TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1(t *testing.T) {
 					// per_unit_storage_throughput is only available with deployment_type=PERSISTENT_1, so we test both here.
 					resource.TestCheckResourceAttr(resourceName, "per_unit_storage_throughput", "50"),
 					resource.TestCheckResourceAttr(resourceName, "deployment_type", fsx.LustreDeploymentTypePersistent1),
+					resource.TestMatchResourceAttr(resourceName, "mount_name", regexp.MustCompile(`^[a-z0-9]+fbmv$`)),


The mount names always have the suffix fbmv, although that isn't documented publicly by AWS, so I don't know if we can consider that stable.

The other options are to just check that it's a lowercase alphanumeric string, or to check that it's not fsx which is the default mount name for SCRATCH_1 deployment types.

i ran the tests and the mount name didnt seem to be ending with fbmv.

testing.go:684: Step 0 error: Check failed: Check 4/4 error: aws_fsx_lustre_file_system.test: Attribute 'mount_name' didn't match "^[a-z0-9]+fbmv$", got "mlvg5bmv"

it doesn't seem to have any logic, according to docs:

For the SCRATCH_1 deployment type, this value is always "fsx". For SCRATCH_2 and PERSISTENT_1 deployment types, this value is a string that is unique within an AWS Region.

Lets change this to be not equal fsx as you proposed. i dont see any other way except just checking the value is set with no other validation.

@DrFaust92 I implemented it as "just checking the value is set with no other validation".

I took a peek around the repository, and found the resource.TestCheckResourceAttrSet used in a bunch of places, which seems expressly for this purpose (a resource that we don't know the value ahead of time). I did not find any resource.TestCheckResourceAttrDoesNotMatch method in the resource go library.

So I figured it would be better to follow the existing convention, and not duplicate complex resource-retrieval logic from github.com/hashicorp/terraform-plugin-sdk/helper/resource. We're not doing any transformation on the mount_name retrieved from AWS, just passing it through, so ultimately I don't think an integration test that checks it's not equal to fsx would do much.

Let me know what you think. I can put together a "not fsx" integration test if you feel strongly.

I think that just checking that the attribute is set is good enough

DrFaust92

LGTM

--- PASS: TestAccAWSFsxLustreFileSystem_basic (689.59s)
--- PASS: TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1 (550.02s)

mtpdt · 2020-08-17T19:05:19Z

@DrFaust92 any next steps needed on my part, or can you merge this in?

ewbankkit

LGTM.

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxLustreFileSystem_basic\|TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1\|TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_basic\|TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1\|TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2 -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== RUN   TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1
=== PAUSE TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1
=== RUN   TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2
=== PAUSE TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2
=== CONT  TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2
=== CONT  TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1
--- PASS: TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1 (472.54s)
--- PASS: TestAccAWSFsxLustreFileSystem_basic (494.94s)
--- PASS: TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2 (597.53s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	597.591s

breathingdust · 2020-09-18T20:30:10Z

Hi @mtpdt 👋
Would you be able to resolve these conflicts? Then we can get this merged!

mtpdt · 2020-09-23T13:30:56Z

@breathingdust merge conflicts resolved.

breathingdust · 2020-09-23T15:48:30Z

LGTM! 🚀 Thanks @mtpdt

Verified Acceptance Tests in Commerical (us-west-2)

make testacc TESTARGS='-run=TestAccAWSFsxLustreFileSystem_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_basic -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_basic
--- PASS: TestAccAWSFsxLustreFileSystem_basic (570.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	572.771s

ghost · 2020-09-24T22:16:02Z

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-10-23T17:10:07Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

DrFaust92 self-requested a review July 23, 2020 07:27

DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 23, 2020

mtpdt marked this pull request as ready for review July 23, 2020 14:39

mtpdt requested a review from a team July 23, 2020 14:39

mtpdt mentioned this pull request Jul 24, 2020

Add deployment type to aws_fsx_lustre_file_system #13639

Merged

DrFaust92 self-assigned this Jul 24, 2020

mtpdt force-pushed the f-aws_fsx_lustre_file_system-mount_name branch 2 times, most recently from ef6ee58 to 73a544e Compare August 1, 2020 17:39

mtpdt commented Aug 1, 2020

View reviewed changes

mtpdt force-pushed the f-aws_fsx_lustre_file_system-mount_name branch from 73a544e to 255b1e3 Compare August 1, 2020 17:52

DrFaust92 removed the request for review from a team August 1, 2020 18:41

mtpdt force-pushed the f-aws_fsx_lustre_file_system-mount_name branch from 255b1e3 to 6dcf684 Compare August 2, 2020 21:58

DrFaust92 approved these changes Aug 3, 2020

View reviewed changes

ewbankkit approved these changes Aug 24, 2020

View reviewed changes

DrFaust92 requested a review from breathingdust September 18, 2020 16:05

mtpdt force-pushed the f-aws_fsx_lustre_file_system-mount_name branch from 6dcf684 to 4a9a886 Compare September 22, 2020 02:42

Add mount_name to aws_fsx_lustre_file_system

0d36e0d

mtpdt force-pushed the f-aws_fsx_lustre_file_system-mount_name branch from 4a9a886 to 0d36e0d Compare September 23, 2020 02:46

DrFaust92 mentioned this pull request Sep 23, 2020

Provide ability to define IP address of primary interface for FSX for Lustre & Windows #14464

Closed

breathingdust added this to the v3.8.0 milestone Sep 23, 2020

breathingdust merged commit 581f8c9 into hashicorp:master Sep 23, 2020

breathingdust added a commit that referenced this pull request Sep 23, 2020

Update CHANGELOG for #14313

ae4bb4e

ghost locked as resolved and limited conversation to collaborators Oct 23, 2020

mtpdt deleted the f-aws_fsx_lustre_file_system-mount_name branch January 4, 2021 19:03

DrFaust92 removed their assignment Jun 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add mount_name to aws_fsx_lustre_file_system #14313

Add mount_name to aws_fsx_lustre_file_system #14313

mtpdt commented Jul 23, 2020 •

edited

Loading

mtpdt commented Jul 23, 2020

DrFaust92 commented Jul 24, 2020

DrFaust92 commented Jul 29, 2020

mtpdt commented Jul 31, 2020

mtpdt Aug 1, 2020

DrFaust92 Aug 1, 2020

mtpdt Aug 2, 2020

DrFaust92 Aug 2, 2020

DrFaust92 left a comment •

edited

Loading

mtpdt commented Aug 17, 2020

ewbankkit left a comment

breathingdust commented Sep 18, 2020

mtpdt commented Sep 23, 2020

breathingdust commented Sep 23, 2020

ghost commented Sep 24, 2020

ghost commented Oct 23, 2020

Add mount_name to aws_fsx_lustre_file_system #14313

Add mount_name to aws_fsx_lustre_file_system #14313

Conversation

mtpdt commented Jul 23, 2020 • edited Loading

Community Note

mtpdt commented Jul 23, 2020

DrFaust92 commented Jul 24, 2020

DrFaust92 commented Jul 29, 2020

mtpdt commented Jul 31, 2020

mtpdt Aug 1, 2020

Choose a reason for hiding this comment

DrFaust92 Aug 1, 2020

Choose a reason for hiding this comment

mtpdt Aug 2, 2020

Choose a reason for hiding this comment

DrFaust92 Aug 2, 2020

Choose a reason for hiding this comment

DrFaust92 left a comment • edited Loading

Choose a reason for hiding this comment

mtpdt commented Aug 17, 2020

ewbankkit left a comment

Choose a reason for hiding this comment

breathingdust commented Sep 18, 2020

mtpdt commented Sep 23, 2020

breathingdust commented Sep 23, 2020

ghost commented Sep 24, 2020

ghost commented Oct 23, 2020

mtpdt commented Jul 23, 2020 •

edited

Loading

DrFaust92 left a comment •

edited

Loading