r/fsx_windows_file_system - add storage type

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12553

Release note for CHANGELOG:

resource_aws_fsx_windows_file_system - add `storage_type` argument.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSFsxWindowsFileSystem_storageTypeHdd (3350.79s)
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (3006.13s)

[ewbankkit]

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxWindowsFileSystem_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxWindowsFileSystem_basic -timeout 120m
=== RUN   TestAccAWSFsxWindowsFileSystem_basic
=== PAUSE TestAccAWSFsxWindowsFileSystem_basic
=== CONT  TestAccAWSFsxWindowsFileSystem_basic
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (3185.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3185.469s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxWindowsFileSystem_storageTypeHdd'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxWindowsFileSystem_storageTypeHdd -timeout 120m
=== RUN   TestAccAWSFsxWindowsFileSystem_storageTypeHdd
=== PAUSE TestAccAWSFsxWindowsFileSystem_storageTypeHdd
=== CONT  TestAccAWSFsxWindowsFileSystem_storageTypeHdd
--- PASS: TestAccAWSFsxWindowsFileSystem_storageTypeHdd (3444.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3444.092s

[breathingdust]

LGTM 🚀 Thanks @DrFaust92!

Verified Acceptance Tests

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxWindowsFileSystem_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxWindowsFileSystem_basic -timeout 120m
=== RUN   TestAccAWSFsxWindowsFileSystem_basic
=== PAUSE TestAccAWSFsxWindowsFileSystem_basic
=== CONT  TestAccAWSFsxWindowsFileSystem_basic
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (3233.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3235.741s

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxWindowsFileSystem_storageTypeHdd'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxWindowsFileSystem_storageTypeHdd -timeout 120m
=== RUN   TestAccAWSFsxWindowsFileSystem_storageTypeHdd
=== PAUSE TestAccAWSFsxWindowsFileSystem_storageTypeHdd
=== CONT  TestAccAWSFsxWindowsFileSystem_storageTypeHdd
--- PASS: TestAccAWSFsxWindowsFileSystem_storageTypeHdd (2331.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2333.889s

[ghost]

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!